Make `ty::Error` implement all auto traits by compiler-errors · Pull Request #134798 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

I have no idea what's up with the crashes test I fixed--I really don't want to look into it since it has to do something with borrowck and multiple layers of opaques. I think the underlying idea of allowing error types to implement all auto traits is justified though.

Fixes #134796
Fixes #131050

r? lcnr

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

I updated the description to close the crash issue.

@bors r+ rollup

📌 Commit f349d72 has been approved by jackh726

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

bors added a commit to rust-lang-ci/rust that referenced this pull request

…iaskrgr

Rollup of 6 pull requests

Successful merges:

rust-lang#133663 (Add a compiler intrinsic to back bigint_helper_methods)
rust-lang#134798 (Make ty::Error implement all auto traits)
rust-lang#134808 (compiletest: Remove empty 'expected' files when blessing)
rust-lang#134809 (Add --no-capture/--nocapture as bootstrap arguments)
rust-lang#134826 (Add spastorino to users_on_vacation)
rust-lang#134828 (Add clubby789 back to bootstrap review rotation)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Rollup merge of rust-lang#134798 - compiler-errors:err-auto, r=jackh726

Make ty::Error implement all auto traits

I have no idea what's up with the crashes test I fixed--I really don't want to look into it since it has to do something with borrowck and multiple layers of opaques. I think the underlying idea of allowing error types to implement all auto traits is justified though.

Fixes rust-lang#134796 Fixes rust-lang#131050

r? lcnr

poliorcetics pushed a commit to poliorcetics/rust that referenced this pull request

Make ty::Error implement all auto traits

I have no idea what's up with the crashes test I fixed--I really don't want to look into it since it has to do something with borrowck and multiple layers of opaques. I think the underlying idea of allowing error types to implement all auto traits is justified though.

Fixes rust-lang#134796 Fixes rust-lang#131050

r? lcnr

poliorcetics pushed a commit to poliorcetics/rust that referenced this pull request

…iaskrgr

Rollup of 6 pull requests

Successful merges:

rust-lang#133663 (Add a compiler intrinsic to back bigint_helper_methods)
rust-lang#134798 (Make ty::Error implement all auto traits)
rust-lang#134808 (compiletest: Remove empty 'expected' files when blessing)
rust-lang#134809 (Add --no-capture/--nocapture as bootstrap arguments)
rust-lang#134826 (Add spastorino to users_on_vacation)
rust-lang#134828 (Add clubby789 back to bootstrap review rotation)

r? @ghost @rustbot modify labels: rollup

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Relevant to the compiler team, which will review and decide on the PR/issue.