Revert style guide rhs break by ehuss · Pull Request #134975 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits2 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

ehuss

This reverts #132369 and #119838. The style-guide change for indentation of rhs was not implemented in time for the 2024 style edition.
See tracking issue #132380.

cc #134974 for the other style guide change in 2024.

r? @compiler-errors

@ehuss

…inop-heuristic-assignment-only, r=calebcartwright"

This reverts commit 348d280, reversing changes made to 526c67f.

@ehuss

…inop-indent, r=compiler-errors"

This reverts commit 3628783, reversing changes made to 31026b7.

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-style

Relevant to the style team, which will review and decide on the PR/issue.

labels

Dec 31, 2024

@rustbot

Some changes occurred in src/doc/style-guide

cc @rust-lang/style

@compiler-errors

@bors

📌 Commit 7a46c7b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 31, 2024

Noratrieb added a commit to Noratrieb/rust that referenced this pull request

Dec 31, 2024

@Noratrieb

…, r=compiler-errors

Revert style guide rhs break

This reverts rust-lang#132369 and rust-lang#119838. The style-guide change for indentation of rhs was not implemented in time for the 2024 style edition. See tracking issue rust-lang#132380.

cc rust-lang#134974 for the other style guide change in 2024.

r? @compiler-errors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 31, 2024

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 1, 2025

@bors

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 1, 2025

@rust-timer

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-style

Relevant to the style team, which will review and decide on the PR/issue.