style-guide: Only use the new binop heuristic for assignments by joshtriplett · Pull Request #132369 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This avoids pathological cases where chains of binops get progressively
deeper.
This avoids pathological cases where chains of binops get progressively deeper.
rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the style team, which will review and decide on the PR/issue.
labels
Some changes occurred in src/doc/style-guide
cc @rust-lang/style
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor suggestion for consideration, but r=me without it
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
📌 Commit d7e6074 has been approved by calebcartwright
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…ristic-assignment-only, r=calebcartwright
style-guide: Only use the new binop heuristic for assignments
This avoids pathological cases where chains of binops get progressively deeper.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#131829 (Remove support for
-Zprofile(gcov-style coverage instrumentation)) - rust-lang#132341 (Reject raw lifetime followed by
', like regular lifetimes do) - rust-lang#132369 (style-guide: Only use the new binop heuristic for assignments)
- rust-lang#132383 (Implement suggestion for never type fallback lints)
- rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate)
- rust-lang#132438 (Remove unncessary option for default rust-analyzer setting)
r? @ghost
@rustbot modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…ristic-assignment-only, r=calebcartwright
style-guide: Only use the new binop heuristic for assignments
This avoids pathological cases where chains of binops get progressively deeper.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 13 pull requests
Successful merges:
- rust-lang#131829 (Remove support for
-Zprofile(gcov-style coverage instrumentation)) - rust-lang#132369 (style-guide: Only use the new binop heuristic for assignments)
- rust-lang#132383 (Implement suggestion for never type fallback lints)
- rust-lang#132437 (coverage: Regression test for inlining into an uninstrumented crate)
- rust-lang#132438 (Remove unncessary option for default rust-analyzer setting)
- rust-lang#132439 (Add
f16andf128toinvalid_nan_comparison) - rust-lang#132445 (Cleanup attributes around unchecked shifts and unchecked negation in const)
- rust-lang#132448 (Add missing backtick)
- rust-lang#132450 (Show actual MIR when MIR building forgot to terminate block)
- rust-lang#132451 (remove some unnecessary rustc_allow_const_fn_unstable)
- rust-lang#132455 (make const_alloc_layout feature gate only about functions that are already stable)
- rust-lang#132456 (Move remaining inline assembly test files into asm directory)
- rust-lang#132459 (feat(byte_sub_ptr): unstably add ptr::byte_sub_ptr)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 14 pull requests
Successful merges:
- rust-lang#131829 (Remove support for
-Zprofile(gcov-style coverage instrumentation)) - rust-lang#132369 (style-guide: Only use the new binop heuristic for assignments)
- rust-lang#132383 (Implement suggestion for never type fallback lints)
- rust-lang#132413 (update offset_of! docs to reflect the stabilization of nesting)
- rust-lang#132438 (Remove unncessary option for default rust-analyzer setting)
- rust-lang#132439 (Add
f16andf128toinvalid_nan_comparison) - rust-lang#132444 (rustdoc: Directly use rustc_abi instead of reexports)
- rust-lang#132445 (Cleanup attributes around unchecked shifts and unchecked negation in const)
- rust-lang#132448 (Add missing backtick)
- rust-lang#132450 (Show actual MIR when MIR building forgot to terminate block)
- rust-lang#132451 (remove some unnecessary rustc_allow_const_fn_unstable)
- rust-lang#132455 (make const_alloc_layout feature gate only about functions that are already stable)
- rust-lang#132456 (Move remaining inline assembly test files into asm directory)
- rust-lang#132459 (feat(byte_sub_ptr): unstably add ptr::byte_sub_ptr)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#132369 - joshtriplett:style-guide-binop-heuristic-assignment-only, r=calebcartwright
style-guide: Only use the new binop heuristic for assignments
This avoids pathological cases where chains of binops get progressively deeper.
ehuss added a commit to ehuss/rust that referenced this pull request
…inop-heuristic-assignment-only, r=calebcartwright"
This reverts commit 348d280, reversing changes made to 526c67f.
Noratrieb added a commit to Noratrieb/rust that referenced this pull request
…, r=compiler-errors
Revert style guide rhs break
This reverts rust-lang#132369 and rust-lang#119838. The style-guide change for indentation of rhs was not implemented in time for the 2024 style edition. See tracking issue rust-lang#132380.
cc rust-lang#134974 for the other style guide change in 2024.
r? @compiler-errors
tgross35 added a commit to tgross35/rust that referenced this pull request
…, r=compiler-errors
Revert style guide rhs break
This reverts rust-lang#132369 and rust-lang#119838. The style-guide change for indentation of rhs was not implemented in time for the 2024 style edition. See tracking issue rust-lang#132380.
cc rust-lang#134974 for the other style guide change in 2024.
r? @compiler-errors
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the style team, which will review and decide on the PR/issue.