Prepare 1.85 beta release by pietroalbini · Pull Request #135163 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation36 Commits6 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the infrastructure team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.
labels
📌 Commit eb92cef has been approved by pietroalbini
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
Prepare 1.85 beta release
r? @ghost
This comment has been minimized.
This comment has been minimized.
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Turns out that replace-version-placeholder replaced... where the placeholder itself is defined. Unsurprisingly things were sad.
Manually removed the broken replacement from the commit, will send a tooling change later.
@bors r+ p=100
📌 Commit f1ac628 has been approved by pietroalbini
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
This comment has been minimized.
@bors r-
PR CI failed. Will investigate.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
Prepare 1.85 beta release
r? @ghost
Congrats bors you're broken.
@bors retry
📌 Commit 3d6fdff has been approved by pietroalbini
It is now in the queue for this repository.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Prepare 1.85 beta release
r? @ghost
This comment has been minimized.
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
The job
dist-i686-msvcfailed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)RustFmtGroup.wxs RustAnalyzerGroup.wxs AnalysisGroup.wxs building `msi` installer with "D:/a/rust/rust/wix\\bin/light.exe" D:\a\rust\rust\build\tmp\dist\combined-tarball\rust.wxs(306) : error LGHT0094 : Unresolved reference to symbol 'WixComponentGroup:MiriGroup' in section 'Product:*'. Command has failed. Rerun with -v to see more details.
Same error as the one encountered when preparing the previous beta version, #133447 (comment)
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
label
📌 Commit b2ab974 has been approved by pietroalbini
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…ark-Simulacrum
Revert rust-lang#131365
This PR reverts rust-lang#131365, following the revert we did on the beta branches for both 1.84 and 1.85.
While the PR passes CI successfully on master, as soon as we branch off beta it starts failing in the newly created beta branch. This caused the release team to revert it for both 1.84 and 1.85, and if nothing is done it would continue being reverted every cycle.
@heiseish (PR author) feel free to submit the PR again in the future: this revert doesn't represent the release team rejecting your change, but just a (hopefully temporary!) revert to ensure future beta branches can be created without reverting it each time.
When submitting the PR again, I recommend you test your changes by configuring rust.channel to both nightly and beta in your config.toml. You can see the latest failure [here](rust-lang#135163 (comment)).
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#135253 - pietroalbini:pa-revert-131365, r=Mark-Simulacrum
Revert rust-lang#131365
This PR reverts rust-lang#131365, following the revert we did on the beta branches for both 1.84 and 1.85.
While the PR passes CI successfully on master, as soon as we branch off beta it starts failing in the newly created beta branch. This caused the release team to revert it for both 1.84 and 1.85, and if nothing is done it would continue being reverted every cycle.
@heiseish (PR author) feel free to submit the PR again in the future: this revert doesn't represent the release team rejecting your change, but just a (hopefully temporary!) revert to ensure future beta branches can be created without reverting it each time.
When submitting the PR again, I recommend you test your changes by configuring rust.channel to both nightly and beta in your config.toml. You can see the latest failure [here](rust-lang#135163 (comment)).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…etroalbini
Include rustc and rustdoc book in replace-version-placeholder
This PR includes the (stable) rustc and rustdoc books which might contain CURRENT_RUSTC_VERSION that should be replaced when branching beta. Include them so they are not forgotten.
I didn't include any other folder or books as they don't strike me as relevant for it and might be problematic in the future if some of the submodules are turned into subtree, because we have places where we wouldn't want to replace them.
cf. rust-lang#135163 (comment)
cc @pietroalbini
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#135221 - Urgau:replace-in-stable-book, r=pietroalbini
Include rustc and rustdoc book in replace-version-placeholder
This PR includes the (stable) rustc and rustdoc books which might contain CURRENT_RUSTC_VERSION that should be replaced when branching beta. Include them so they are not forgotten.
I didn't include any other folder or books as they don't strike me as relevant for it and might be problematic in the future if some of the submodules are turned into subtree, because we have places where we wouldn't want to replace them.
cf. rust-lang#135163 (comment)
cc @pietroalbini
Labels
Area: port run-make Makefiles to rmake.rs
Area: The testsuite used to check the correctness of rustc
This PR was explicitly merged by bors.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the infrastructure team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.