Add `explicit_extern_abis` Feature and Enforce Explicit ABIs by obeis · Pull Request #135340 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation82 Commits3 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

The unstable explicit_extern_abis feature is introduced, requiring explicit ABIs in extern blocks. Hard errors will be enforced with this feature enabled in a future edition.

RFC rust-lang/rfcs#3722

Update #134986

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Jan 10, 2025

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@rustbot labels +S-blocked
@rustbot author

We're still finalizing the timing and name of the next edition, and in any case, I think I'd like to see a separate PR for adding the various bits for the next edition that's separate from any edition item.

rustbot added S-blocked

Status: Blocked on something else such as an RFC or other implementation work.

S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 10, 2025

This comment has been minimized.

I do not think we will accept the edition changes being folded into this PR, @obeis

This comment has been minimized.

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

traviscross added S-waiting-on-team

Status: Awaiting decision from the relevant subteam (see the T- label).

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jan 12, 2025

Amanieu removed the T-libs

Relevant to the library team, which will review and decide on the PR/issue.

label

Jan 22, 2025

also add explicit-extern-abis feature section to the unstable book.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 15, 2025

I second @traviscross's review comments, and r=me once they are addressed.

This comment was marked as duplicate.

rustbot removed the S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

label

Apr 16, 2025

This comment was marked as duplicate.

@obeis: 🔑 Insufficient privileges: not in try users

@bors r=traviscross,nadrieril rollup

📌 Commit d17c04e has been approved by traviscross,nadrieril

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 16, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 17, 2025

…iaskrgr

Rollup of 9 pull requests

Successful merges:

rust-lang#135340 (Add explicit_extern_abis Feature and Enforce Explicit ABIs)
rust-lang#139440 (rustc_target: RISC-V: feature addition batch 2)
rust-lang#139667 (cfi: Remove #[no_sanitize(cfi)] for extern weak functions)
rust-lang#139828 (Don't require rigid alias's trait to hold)
rust-lang#139854 (Improve parse errors for stray lifetimes in type position)
rust-lang#139889 (Clean UI tests 3 of n)
rust-lang#139894 (Fix opt-dist CLI flag and make it work without LLD)
rust-lang#139900 (stepping into impls for normalization is unproductive)
rust-lang#139915 (replace some #[rustc_intrinsic] usage with use of the libcore declarations)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Apr 17, 2025

Rollup merge of rust-lang#135340 - obeis:explicit-extern-abis, r=traviscross,nadrieril

Add explicit_extern_abis Feature and Enforce Explicit ABIs

The unstable explicit_extern_abis feature is introduced, requiring explicit ABIs in extern blocks. Hard errors will be enforced with this feature enabled in a future edition.

RFC rust-lang/rfcs#3722

Update rust-lang#134986

obeis deleted the explicit-extern-abis branch