Only assert the Parser size on specific arches by cuviper · Pull Request #135855 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The size of this struct depends on the alignment of u128, for example
powerpc64le and s390x have align-8 and end up with only 280 bytes. Our
64-bit tier-1 arches are the same though, so let's just assert on those.
r? nnethercote
The size of this struct depends on the alignment of u128, for example
powerpc64le and s390x have align-8 and end up with only 280 bytes. Our
64-bit tier-1 arches are the same though, so let's just assert on those.
Could not assign reviewer from: nnethercote.
User(s) nnethercote are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.
r? @oli-obk
rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
I'm nominating this for backport because I ran into this problem on Fedora for 1.85-beta:
#133793 (comment)
@rustbot label +beta-nominated
Nick is on vacation so the assignment didn't go through but I think we can go-ahead and merge this now.
@bors r+
📌 Commit aef640a has been approved by wesleywiser
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
| // nonterminals. Make sure it doesn't unintentionally get bigger. |
|---|
| #[cfg(all(target_pointer_width = "64", not(target_arch = "s390x")))] |
| // nonterminals. Make sure it doesn't unintentionally get bigger. We only check a few arches |
| // though, because `TokenTypeSet(u128)` alignment varies on others, changing the total size. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either that, or put #[repr(packed(8))] directly on TokenTypeSet too. I have no idea if there are enough of these being passed around to really matter though.
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
Only assert the Parser size on specific arches
The size of this struct depends on the alignment of u128, for example
powerpc64le and s390x have align-8 and end up with only 280 bytes. Our
64-bit tier-1 arches are the same though, so let's just assert on those.
r? nnethercote
bors added a commit to rust-lang-ci/rust that referenced this pull request
jhpratt added a commit to jhpratt/rust that referenced this pull request
Only assert the Parser size on specific arches
The size of this struct depends on the alignment of u128, for example
powerpc64le and s390x have align-8 and end up with only 280 bytes. Our
64-bit tier-1 arches are the same though, so let's just assert on those.
r? nnethercote
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- rust-lang#133138 (Target modifiers (special marked options) are recorded in metainfo)
- rust-lang#133154 (Reword resolve errors caused by likely missing crate in dep tree)
- rust-lang#135366 (Enable
unreachable_publint intestandproc_macrocrates) - rust-lang#135638 (Make it possible to build GCC on CI)
- rust-lang#135648 (support wasm inline assembly in
naked_asm!) - rust-lang#135827 (CI: free disk with in-tree script instead of GitHub Action)
- rust-lang#135855 (Only assert the
Parsersize on specific arches) - rust-lang#135878 (ci: use 8 core arm runner for dist-aarch64-linux)
- rust-lang#135905 (Enable kernel sanitizers for aarch64-unknown-none-softfloat)
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Only assert the Parser size on specific arches
The size of this struct depends on the alignment of u128, for example
powerpc64le and s390x have align-8 and end up with only 280 bytes. Our
64-bit tier-1 arches are the same though, so let's just assert on those.
r? nnethercote
Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.
@rustbot label +beta-accepted
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- rust-lang#133154 (Reword resolve errors caused by likely missing crate in dep tree)
- rust-lang#135366 (Enable
unreachable_publint intestandproc_macrocrates) - rust-lang#135638 (Make it possible to build GCC on CI)
- rust-lang#135648 (support wasm inline assembly in
naked_asm!) - rust-lang#135827 (CI: free disk with in-tree script instead of GitHub Action)
- rust-lang#135855 (Only assert the
Parsersize on specific arches) - rust-lang#135878 (ci: use 8 core arm runner for dist-aarch64-linux)
- rust-lang#135905 (Enable kernel sanitizers for aarch64-unknown-none-softfloat)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- rust-lang#133154 (Reword resolve errors caused by likely missing crate in dep tree)
- rust-lang#135366 (Enable
unreachable_publint intestandproc_macrocrates) - rust-lang#135638 (Make it possible to build GCC on CI)
- rust-lang#135648 (support wasm inline assembly in
naked_asm!) - rust-lang#135827 (CI: free disk with in-tree script instead of GitHub Action)
- rust-lang#135855 (Only assert the
Parsersize on specific arches) - rust-lang#135878 (ci: use 8 core arm runner for dist-aarch64-linux)
- rust-lang#135905 (Enable kernel sanitizers for aarch64-unknown-none-softfloat)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#135366 (Enable
unreachable_publint intestandproc_macrocrates) - rust-lang#135638 (Make it possible to build GCC on CI)
- rust-lang#135648 (support wasm inline assembly in
naked_asm!) - rust-lang#135827 (CI: free disk with in-tree script instead of GitHub Action)
- rust-lang#135855 (Only assert the
Parsersize on specific arches) - rust-lang#135878 (ci: use 8 core arm runner for dist-aarch64-linux)
- rust-lang#135905 (Enable kernel sanitizers for aarch64-unknown-none-softfloat)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#135855 - cuviper:parser-size, r=wesleywiser
Only assert the Parser size on specific arches
The size of this struct depends on the alignment of u128, for example
powerpc64le and s390x have align-8 and end up with only 280 bytes. Our
64-bit tier-1 arches are the same though, so let's just assert on those.
r? nnethercote
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#135366 (Enable
unreachable_publint intestandproc_macrocrates) - rust-lang#135638 (Make it possible to build GCC on CI)
- rust-lang#135648 (support wasm inline assembly in
naked_asm!) - rust-lang#135827 (CI: free disk with in-tree script instead of GitHub Action)
- rust-lang#135855 (Only assert the
Parsersize on specific arches) - rust-lang#135878 (ci: use 8 core arm runner for dist-aarch64-linux)
- rust-lang#135905 (Enable kernel sanitizers for aarch64-unknown-none-softfloat)
r? @ghost
@rustbot modify labels: rollup
Labels
Accepted for backporting to the compiler in the beta channel.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.