Tidy Python improvements by Kobzol · Pull Request #135950 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation24 Commits4 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Fixes display of Python formatting diffs in tidy, and refactors the code to make it simpler and more robust. Also documents Python formatting and linting in the Rustc dev guide.

Fixes: #135942

r? @onur-ozkan

Could not assign reviewer from: onur-ozkan.
User(s) onur-ozkan are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to r=me

Could not assign reviewer from: onur-ozkan. User(s) onur-ozkan are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

I guess rustbot doesn't allow users from vacation list to r other people 🤔

Could not assign reviewer from: onur-ozkan.
User(s) onur-ozkan are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

Asked about this in the compiler thread

Could not assign reviewer from: onur-ozkan.
User(s) onur-ozkan are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

onur-ozkan has insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee.

(see documentation)

onur-ozkan has insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee.

(see documentation)

Dude it's fine just let me take it

onur-ozkan has insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee.

(see documentation)

Unify the logic under a simple function to make it harder to cause mistakes.

📌 Commit 0f334ec has been approved by onur-ozkan

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 24, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jan 24, 2025

…=onur-ozkan

Tidy Python improvements

Fixes display of Python formatting diffs in tidy, and refactors the code to make it simpler and more robust. Also documents Python formatting and linting in the Rustc dev guide.

Fixes: rust-lang#135942

r? @onur-ozkan

Could not assign reviewer from: onur-ozkan.
User(s) onur-ozkan are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

Could not assign reviewer from: apir.
User(s) apir are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

Could not assign reviewer from: onur-ozkan.
User(s) onur-ozkan are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 24, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

rust-lang#135295 (Check empty SIMD vector in inline asm)
rust-lang#135873 (coverage: Prepare for upcoming changes to counter creation)
rust-lang#135926 (Implement needs-subprocess directive, and cleanup a bunch of tests to use needs-{subprocess,threads})
rust-lang#135950 (Tidy Python improvements)
rust-lang#135956 (Make Vec::pop_if a bit more presentable)
rust-lang#135966 ([AIX] Allow different sized load and store in tests/assembly/powerpc64-struct-abi.rs)
rust-lang#135983 (Doc difference between extend and extend_from_slice)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 24, 2025

…iaskrgr

Rollup of 6 pull requests

Successful merges:

rust-lang#135873 (coverage: Prepare for upcoming changes to counter creation)
rust-lang#135926 (Implement needs-subprocess directive, and cleanup a bunch of tests to use needs-{subprocess,threads})
rust-lang#135950 (Tidy Python improvements)
rust-lang#135956 (Make Vec::pop_if a bit more presentable)
rust-lang#135966 ([AIX] Allow different sized load and store in tests/assembly/powerpc64-struct-abi.rs)
rust-lang#135983 (Doc difference between extend and extend_from_slice)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 24, 2025

Rollup merge of rust-lang#135950 - Kobzol:tidy-python-improvements, r=onur-ozkan

Tidy Python improvements

Fixes display of Python formatting diffs in tidy, and refactors the code to make it simpler and more robust. Also documents Python formatting and linting in the Rustc dev guide.

Fixes: rust-lang#135942

r? @onur-ozkan

Kobzol deleted the tidy-python-improvements branch