Arbitrary self types v2: explain test. by adetaylor · Pull Request #136124 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The purpose of this test wasn't obvious, as @traviscross noted. Add a comment.
Confession: although this test was added to demonstrate this particular corner-case, I can no longer reproduce the original problem, even if I adjust rustc to do the "wrong" thing. I have spent several hours trying to adjust the case to trigger the "faulty" behavior with no success. This test may therefore not be as useful as it originally was. But it still seems worthwhile retaining as a regression test that we don't break things in these quirky circumstances. Ideally we'd find a new test which tests this behavior but I've failed to come up with one.
r? @traviscross
The purpose of this test wasn't obvious. Add a comment.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
r? compiler-errors @bors r+ rollup
📌 Commit d898aa3 has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Zalathar added a commit to Zalathar/rust that referenced this pull request
…-errors
Arbitrary self types v2: explain test.
The purpose of this test wasn't obvious, as @traviscross noted. Add a comment.
Confession: although this test was added to demonstrate this particular corner-case, I can no longer reproduce the original problem, even if I adjust rustc to do the "wrong" thing. I have spent several hours trying to adjust the case to trigger the "faulty" behavior with no success. This test may therefore not be as useful as it originally was. But it still seems worthwhile retaining as a regression test that we don't break things in these quirky circumstances. Ideally we'd find a new test which tests this behavior but I've failed to come up with one.
r? @traviscross
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#133151 (Trim extra whitespace in fn ptr suggestion span)
- rust-lang#133929 (Remove -Zinline-in-all-cgus and clean up tests/codegen-units/)
- rust-lang#135886 (Document purpose of closure in from_fn.rs more clearly)
- rust-lang#135961 (Fix 2/4 tests skipped by opt-dist)
- rust-lang#136104 (Add mermaid graphs of NLL regions and SCCs to polonius MIR dump)
- rust-lang#136124 (Arbitrary self types v2: explain test.)
- rust-lang#136153 (Locate asan-odr-win with other sanitizer tests)
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…-errors
Arbitrary self types v2: explain test.
The purpose of this test wasn't obvious, as @traviscross noted. Add a comment.
Confession: although this test was added to demonstrate this particular corner-case, I can no longer reproduce the original problem, even if I adjust rustc to do the "wrong" thing. I have spent several hours trying to adjust the case to trigger the "faulty" behavior with no success. This test may therefore not be as useful as it originally was. But it still seems worthwhile retaining as a regression test that we don't break things in these quirky circumstances. Ideally we'd find a new test which tests this behavior but I've failed to come up with one.
r? @traviscross
This was referenced
Jan 28, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#135869 (Make docs for AtomicUsize::from_mut platform-independent)
- rust-lang#135892 (-Znext-solver: "normalize" signature before checking it mentions self in
deduce_closure_signature) - rust-lang#136055 (Implement MIR const trait stability checks)
- rust-lang#136066 (Pass spans to
perform_locally_in_new_solver) - rust-lang#136071 ([Clippy] Add vec_reserve & vecdeque_reserve diagnostic items)
- rust-lang#136124 (Arbitrary self types v2: explain test.)
- rust-lang#136149 (Flip the
rustc-rayon/indexmapdependency order) - rust-lang#136173 (Update comments and sort target_arch in c_char_definition)
- rust-lang#136178 (Update username in build helper example)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#136124 - adetaylor:test-comment, r=compiler-errors
Arbitrary self types v2: explain test.
The purpose of this test wasn't obvious, as @traviscross noted. Add a comment.
Confession: although this test was added to demonstrate this particular corner-case, I can no longer reproduce the original problem, even if I adjust rustc to do the "wrong" thing. I have spent several hours trying to adjust the case to trigger the "faulty" behavior with no success. This test may therefore not be as useful as it originally was. But it still seems worthwhile retaining as a regression test that we don't break things in these quirky circumstances. Ideally we'd find a new test which tests this behavior but I've failed to come up with one.
r? @traviscross
96 tasks
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#135869 (Make docs for AtomicUsize::from_mut platform-independent)
- rust-lang#135892 (-Znext-solver: "normalize" signature before checking it mentions self in
deduce_closure_signature) - rust-lang#136055 (Implement MIR const trait stability checks)
- rust-lang#136066 (Pass spans to
perform_locally_in_new_solver) - rust-lang#136071 ([Clippy] Add vec_reserve & vecdeque_reserve diagnostic items)
- rust-lang#136124 (Arbitrary self types v2: explain test.)
- rust-lang#136149 (Flip the
rustc-rayon/indexmapdependency order) - rust-lang#136173 (Update comments and sort target_arch in c_char_definition)
- rust-lang#136178 (Update username in build helper example)
r? @ghost
@rustbot modify labels: rollup
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.