Use short ty string for binop and unop errors by estebank · Pull Request #136315 · rust-lang/rust (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jan 30, 2025

estebank changed the titleUse short ty string for binop errors Use short ty string for binop and unop errors

Jan 31, 2025

estebank added the S-blocked

Status: Blocked on something else such as an RFC or other implementation work.

label

Jan 31, 2025

error[E0369]: cannot add `((..., ..., ..., ...), ..., ..., ...)` to `((..., ..., ..., ...), ..., ..., ...)`
  --> $DIR/binop.rs:9:7
   |
LL |     x + x;
   |     - ^ - ((..., ..., ..., ...), ..., ..., ...)
   |     |
   |     ((..., ..., ..., ...), ..., ..., ...)
   |
   = note: the full name for the type has been written to '$TEST_BUILD_DIR/$FILE.long-type-hash.txt'
   = note: consider using `--verbose` to print the full type name to the console

error[E0600]: cannot apply unary operator `!` to type `(..., ..., ..., ...)`
  --> $DIR/binop.rs:14:5
   |
LL |     !x;
   |     ^^ cannot apply unary operator `!`
   |
   = note: the full name for the type has been written to '$TEST_BUILD_DIR/$FILE.long-type-hash.txt'
   = note: consider using `--verbose` to print the full type name to the console

CC rust-lang#135919.

estebank removed the S-blocked

Status: Blocked on something else such as an RFC or other implementation work.

label

Feb 2, 2025

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Feb 6, 2025

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Feb 6, 2025

Use short ty string for binop and unop errors

error[E0369]: cannot add `(..., ..., ..., ...)` to `(..., ..., ..., ...)`
  --> $DIR/binop.rs:10:7
   |
LL |     x + x;
   |     - ^ - (..., ..., ..., ...)
   |     |
   |     (..., ..., ..., ...)
   |
   = note: the full name for the type has been written to '$TEST_BUILD_DIR/$FILE.long-type-hash.txt'
   = note: consider using `--verbose` to print the full type name to the console

error[E0600]: cannot apply unary operator `!` to type `(..., ..., ..., ...)`
  --> $DIR/binop.rs:14:5
   |
LL |     !x;
   |     ^^ cannot apply unary operator `!`
   |
   = note: the full name for the type has been written to '$TEST_BUILD_DIR/$FILE.long-type-hash.txt'
   = note: consider using `--verbose` to print the full type name to the console

CC rust-lang#135919.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 6, 2025

…kingjubilee

Rollup of 9 pull requests

Successful merges:

• rust-lang#135439 (Make -O mean OptLevel::Aggressive)
• rust-lang#136193 (Implement pattern type ffi checks)
• rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern)
• rust-lang#136311 (Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types)
• rust-lang#136315 (Use short ty string for binop and unop errors)
• rust-lang#136393 (Fix accidentally not emitting overflowing literals lints anymore in patterns)
• rust-lang#136530 (Implement x perf directly in bootstrap)
• rust-lang#136580 (Couple of changes to run rustc in miri)
• rust-lang#136589 (Enable "jump to def" feature on rustc docs)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 6, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#136073 (Always compute coroutine layout for eagerly emitting recursive layout errors)
• rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern)
• rust-lang#136311 (Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types)
• rust-lang#136315 (Use short ty string for binop and unop errors)
• rust-lang#136393 (Fix accidentally not emitting overflowing literals lints anymore in patterns)
• rust-lang#136435 (Simplify some code for lowering THIR patterns)
• rust-lang#136630 (Change two std process tests to not output to std{out,err}, and fix test suite stat reset in bootstrap CI test rendering)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 6, 2025

Rollup of 7 pull requests

Successful merges:

• rust-lang#136073 (Always compute coroutine layout for eagerly emitting recursive layout errors)
• rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern)
• rust-lang#136311 (Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types)
• rust-lang#136315 (Use short ty string for binop and unop errors)
• rust-lang#136393 (Fix accidentally not emitting overflowing literals lints anymore in patterns)
• rust-lang#136435 (Simplify some code for lowering THIR patterns)
• rust-lang#136630 (Change two std process tests to not output to std{out,err}, and fix test suite stat reset in bootstrap CI test rendering)

r? @ghost @rustbot modify labels: rollup

try-job: aarch64-gnu-debug

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 6, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#136073 (Always compute coroutine layout for eagerly emitting recursive layout errors)
• rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern)
• rust-lang#136311 (Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types)
• rust-lang#136315 (Use short ty string for binop and unop errors)
• rust-lang#136393 (Fix accidentally not emitting overflowing literals lints anymore in patterns)
• rust-lang#136435 (Simplify some code for lowering THIR patterns)
• rust-lang#136630 (Change two std process tests to not output to std{out,err}, and fix test suite stat reset in bootstrap CI test rendering)

r? @ghost @rustbot modify labels: rollup

try-job: aarch64-gnu-debug

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 6, 2025

…kingjubilee

Rollup of 9 pull requests

Successful merges:

• rust-lang#135439 (Make -O mean OptLevel::Aggressive)
• rust-lang#136193 (Implement pattern type ffi checks)
• rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern)
• rust-lang#136311 (Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types)
• rust-lang#136315 (Use short ty string for binop and unop errors)
• rust-lang#136393 (Fix accidentally not emitting overflowing literals lints anymore in patterns)
• rust-lang#136530 (Implement x perf directly in bootstrap)
• rust-lang#136580 (Couple of changes to run rustc in miri)
• rust-lang#136589 (Enable "jump to def" feature on rustc docs)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Feb 6, 2025

Rollup merge of rust-lang#136315 - estebank:long-ty-binop, r=SparrowLii

Use short ty string for binop and unop errors

error[E0369]: cannot add `(..., ..., ..., ...)` to `(..., ..., ..., ...)`
  --> $DIR/binop.rs:10:7
   |
LL |     x + x;
   |     - ^ - (..., ..., ..., ...)
   |     |
   |     (..., ..., ..., ...)
   |
   = note: the full name for the type has been written to '$TEST_BUILD_DIR/$FILE.long-type-hash.txt'
   = note: consider using `--verbose` to print the full type name to the console

error[E0600]: cannot apply unary operator `!` to type `(..., ..., ..., ...)`
  --> $DIR/binop.rs:14:5
   |
LL |     !x;
   |     ^^ cannot apply unary operator `!`
   |
   = note: the full name for the type has been written to '$TEST_BUILD_DIR/$FILE.long-type-hash.txt'
   = note: consider using `--verbose` to print the full type name to the console

CC rust-lang#135919.

flip1995 pushed a commit to flip1995/rust that referenced this pull request

Feb 20, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#136073 (Always compute coroutine layout for eagerly emitting recursive layout errors)
• rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern)
• rust-lang#136311 (Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types)
• rust-lang#136315 (Use short ty string for binop and unop errors)
• rust-lang#136393 (Fix accidentally not emitting overflowing literals lints anymore in patterns)
• rust-lang#136435 (Simplify some code for lowering THIR patterns)
• rust-lang#136630 (Change two std process tests to not output to std{out,err}, and fix test suite stat reset in bootstrap CI test rendering)

r? @ghost @rustbot modify labels: rollup

try-job: aarch64-gnu-debug