rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This code detects the case where one of the borrows is inside the let init expr while the other end is not. If that happens, we don't want to suggest adding a semicolon, because it won't work.

Fixes #133941

This code detects the case where one of the borrows is inside the let init expr while the other end is not. If that happens, we don't want to suggest adding a semicolon, because it won't work.

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Feb 1, 2025

r? compiler-errors @bors r+ rollup

📌 Commit ecb2d5c has been approved by compiler-errors

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Feb 2, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 2, 2025

…tor, r=compiler-errors

diagnostics: fix borrowck suggestions for if/while let conditionals

This code detects the case where one of the borrows is inside the let init expr while the other end is not. If that happens, we don't want to suggest adding a semicolon, because it won't work.

Fixes rust-lang#133941

This was referenced

Feb 2, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 2, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

rust-lang#134272 (Remove rustc_encodable_decodable feature)
rust-lang#136283 (Update encode_utf16 to mention it is native endian)
rust-lang#136394 (Clean up MonoItem::instantiation_mode)
rust-lang#136402 (diagnostics: fix borrowck suggestions for if/while let conditionals)
rust-lang#136415 (Highlight clarifying information in "expected/found" error)
rust-lang#136422 (Convert two rustc_middle::lint functions to Span methods.)
rust-lang#136434 (rustc_allowed_through_unstable_modules: require deprecation message)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Feb 2, 2025

Rollup merge of rust-lang#136402 - notriddle:notriddle/let-expr-detector, r=compiler-errors

diagnostics: fix borrowck suggestions for if/while let conditionals

This code detects the case where one of the borrows is inside the let init expr while the other end is not. If that happens, we don't want to suggest adding a semicolon, because it won't work.

Fixes rust-lang#133941

notriddle deleted the notriddle/let-expr-detector branch

February 3, 2025 15:42

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.