i686-linux-android: increase CPU baseline to Pentium 4 (without an actual change by RalfJung · Pull Request #136885 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
As per @maurer's comment, this shouldn't actually change anything since we anyway add a bunch of extensions that bump things up way beyond Pentium 4. But Pentium 4 is consistent with the other i686 targets and I don't know enough about the exact sequence of CPU generations to be confident with more than this. ;)
r? @ehuss
rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, you can r=me unless you'd like the target maintainer to double-check w/ the wording. I don't think this needs relnotes because this is more of an advisory thing anyway (since other extensions are needed).
As the target maintainer, LGTM.
Thanks for the double-check.
@bors r+ rollup
📌 Commit 9d8ffe4 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…=jieyouxu
i686-linux-android: increase CPU baseline to Pentium 4 (without an actual change
As per @maurer's [comment](rust-lang#136495 (comment)), this shouldn't actually change anything since we anyway add a bunch of extensions that bump things up way beyond Pentium 4. But Pentium 4 is consistent with the other i686 targets and I don't know enough about the exact sequence of CPU generations to be confident with more than this. ;)
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#135549 (Document some safety constraints and use more safe wrappers)
- rust-lang#135965 (In "specify type" suggestion, skip type params that are already known)
- rust-lang#136193 (Implement pattern type ffi checks)
- rust-lang#136646 (Add a TyPat in the AST to reuse the generic arg lowering logic)
- rust-lang#136699 (std: replace the
FromInnerimplementation for addresses with private conversion functions) - rust-lang#136874 (Change the issue number for
likely_unlikelyandcold_path) - rust-lang#136884 (Lower fn items as ZST valtrees and delay a bug)
- rust-lang#136885 (i686-linux-android: increase CPU baseline to Pentium 4 (without an actual change)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#135549 (Document some safety constraints and use more safe wrappers)
- rust-lang#135965 (In "specify type" suggestion, skip type params that are already known)
- rust-lang#136193 (Implement pattern type ffi checks)
- rust-lang#136646 (Add a TyPat in the AST to reuse the generic arg lowering logic)
- rust-lang#136874 (Change the issue number for
likely_unlikelyandcold_path) - rust-lang#136884 (Lower fn items as ZST valtrees and delay a bug)
- rust-lang#136885 (i686-linux-android: increase CPU baseline to Pentium 4 (without an actual change)
- rust-lang#136891 (Check sig for errors before checking for unconstrained anonymous lifetime)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#136885 - RalfJung:linux-android-base-cpu, r=jieyouxu
i686-linux-android: increase CPU baseline to Pentium 4 (without an actual change
As per @maurer's [comment](rust-lang#136495 (comment)), this shouldn't actually change anything since we anyway add a bunch of extensions that bump things up way beyond Pentium 4. But Pentium 4 is consistent with the other i686 targets and I don't know enough about the exact sequence of CPU generations to be confident with more than this. ;)
Labels
Operating system: Android
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.