Stabilize flags for doctest cross compilation by ehuss · Pull Request #137096 · rust-lang/rust (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

ehuss

This makes the following changes in preparation for supporting doctest cross-compiling in cargo:

These changes were suggested in https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/stabilizing.20doctest.20xcompile/near/409281127

The intent is to stabilize the doctest-xcompile feature in cargo. This will help ensure that for projects that do cross-compile testing that their doctests are also covered. Currently there is a somewhat surprising behavior that they are ignored.

Closes #64245

try-job: x86_64-msvc-1

@rustbot

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

T-rustdoc-frontend

Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

labels

Feb 15, 2025

@fmease fmease added the needs-fcp

This change is insta-stable, so needs a completed FCP to proceed.

label

Feb 15, 2025

@ehuss ehuss mentioned this pull request

Feb 15, 2025

@rust-log-analyzer

This comment has been minimized.

@rustbot

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

The Miri subtree was changed

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

@bors

@ehuss

@GuillaumeGomez

On my review list now. :)

GuillaumeGomez

@GuillaumeGomez

I think they've been around for enough time. Let's start an FCP then.

@rfcbot fcp merge

@rfcbot

notriddle

@ehuss

In playing around with this, I noticed a slight annoyance when using --edition=2024 and mergeable tests. It always prints:

WARNING: No rustdoc doctest environment variable provided so doctests will be run in the same process

I'm wondering if it would make sense to somehow silence that warning when using --test-runtool?

I'm also wondering if it is the right choice to run in the same process. I could see arguments either way. Let me know if you have any opinion on that.

@rust-log-analyzer

This comment has been minimized.

@ehuss

@ehuss

This renames --runtool and --runtool-arg to --test-runtool and --test-runtool-arg to maintain consistency with other --test-* arguments.

@ehuss

@ehuss

This removes the --enable-per-target-ignores and enables it unconditionally.

notriddle

@ehuss

@notriddle

@fmease

@rfcbot resolve forwarding-multi-args-mechanism

I'll be creating a separate PR for these flags.

@rfcbot

🔔 This is now entering its final comment period, as per the review above. 🔔

This was referenced

Apr 15, 2025

@rfcbot

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@fmease

Thanks everyone! @bors r+ rollup

@bors

📌 Commit 115341f has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-team

Status: Awaiting decision from the relevant subteam (see the T- label).

labels

Apr 24, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 25, 2025

@bors

…iaskrgr

Rollup of 8 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 25, 2025

@bors

…iaskrgr

Rollup of 8 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Apr 25, 2025

@rust-timer

Rollup merge of rust-lang#137096 - ehuss:stabilize-doctest-xcompile, r=fmease

Stabilize flags for doctest cross compilation

This makes the following changes in preparation for supporting doctest cross-compiling in cargo:

These changes were suggested in https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/stabilizing.20doctest.20xcompile/near/409281127

The intent is to stabilize the doctest-xcompile feature in cargo. This will help ensure that for projects that do cross-compile testing that their doctests are also covered. Currently there is a somewhat surprising behavior that they are ignored.

Closes rust-lang#64245

try-job: x86_64-msvc-1

ehuss added a commit to ehuss/cargo that referenced this pull request

Apr 25, 2025

@ehuss

This updates the flags used for doctest xcompile to match the upstream changes in rust-lang/rust#137096 which renamed the flag.

ehuss added a commit to ehuss/cargo that referenced this pull request

Apr 25, 2025

@ehuss

This updates the flags used for doctest xcompile to match the upstream changes in rust-lang/rust#137096 which renamed and stabilized the flags.

@ehuss ehuss mentioned this pull request

Apr 25, 2025

ehuss added a commit to ehuss/cargo that referenced this pull request

Apr 26, 2025

@ehuss

This updates the flags used for doctest xcompile to match the upstream changes in rust-lang/rust#137096 which renamed and stabilized the flags.

github-merge-queue bot pushed a commit to rust-lang/cargo that referenced this pull request

Apr 26, 2025

@weihanglo

This updates the flags used for doctest xcompile to match the upstream changes in rust-lang/rust#137096 which renamed and stabilized the flags.

This cannot be merged until after nightly is published tonight.

@ehuss ehuss mentioned this pull request

Apr 28, 2025

Labels

A-run-make

Area: port run-make Makefiles to rmake.rs

disposition-merge

This issue / PR is in PFCP or FCP with a disposition to merge it.

finished-final-comment-period

The final comment period is finished for this PR / Issue.

needs-fcp

This change is insta-stable, so needs a completed FCP to proceed.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

T-rustdoc-frontend

Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

to-announce

Announce this issue on triage meeting