test: Enable extern-fn-reachable test by klutzy · Pull Request #13741 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

It didn't work because it tried to call itself but symbols are not
exported as default in executables.

Note that fun5 is not internal anymore since it is in library.

Second commit removes/updates some old tests.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file will need a license header (due to tidy)

It didn't work because it tried to call itself but symbols are not exported as default in executables.

Note that fun5 is not internal anymore since it is in library.

Ugh. looks like mac32 also doesn't like tag-align-dyn-variants. (the test passes on mac64, android and win32)
Added ignore-macos.

(also updated run-pass/{tag-align-dyn-u64, tag-align-u64}.rs)

bors added a commit that referenced this pull request

Apr 25, 2014

It didn't work because it tried to call itself but symbols are not exported as default in executables.

Note that fun5 is not internal anymore since it is in library.

Second commit removes/updates some old tests.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 13, 2025

…, r=

tests: Port extern-fn-reachable to rmake.rs

Part of rust-lang#121876.

Summary

This PR ports tests/run-make/extern-fn-reachable to use rmake.rs. Notable changes:

• We now use the object crate and look at the exported symbols specifically.
• This test's coverage regressed against windows-msvc back in replace dynamic library module with libloading rust-lang#90716, but since we use object now, we're able to claw the test coverage back.
• The checks are now stricter:
  1. It no longer looks for substring symbol matches in nm textual outputs, it inspects the symbol names precisely.
  2. We now also explicitly check for the presence of leading underscore in exported symbol names on apple vs non-apple targets.

History

• Test was initially introduced as a run-pass[^run-pass] test as part of Don't mark reachable extern fns as internal rust-lang#10539.
• Test re-introduced as a run-make test in rust-lang#13741.
• Later, the test coverage regressed in rust-lang#90716.

[^run-pass]: no longer a thing nowadays

Supersedes rust-lang#128314. Co-authored with @lolbinarycat.

r? @ghost

try-job: x86_64-msvc try-job: i686-msvc try-job: i686-mingw try-job: x86_64-mingw-1 try-job: x86_64-apple-1 try-job: aarch64-apple try-job: test-various

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 14, 2025

…, r=

tests: Port extern-fn-reachable to rmake.rs

Part of rust-lang#121876.

Summary

This PR ports tests/run-make/extern-fn-reachable to use rmake.rs. Notable changes:

• We now use the object crate and look at the exported symbols specifically.
• This test's coverage regressed against windows-msvc back in replace dynamic library module with libloading rust-lang#90716, but since we use object now, we're able to claw the test coverage back.
• The checks are now stricter:
  1. It no longer looks for substring symbol matches in nm textual outputs, it inspects the symbol names precisely.
  2. We now also explicitly check for the presence of leading underscore in exported symbol names on apple vs non-apple targets.
• Added another case of #[no_mangle] fn fun6() {} (note the lack of pub) to check that Rust nameres visibility is orthogonal to symbol visiblity in dylib.

History

• Test was initially introduced as a run-pass[^run-pass] test as part of Don't mark reachable extern fns as internal rust-lang#10539.
• Test re-introduced as a run-make test in rust-lang#13741.
• Later, the test coverage regressed in rust-lang#90716.

[^run-pass]: no longer a thing nowadays

Supersedes rust-lang#128314. Co-authored with @lolbinarycat.

r? @ghost

try-job: x86_64-msvc try-job: i686-msvc try-job: i686-mingw try-job: x86_64-mingw-1 try-job: x86_64-apple-1 try-job: aarch64-apple try-job: test-various

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 16, 2025

…, r=lqd

tests: Port extern-fn-reachable to rmake.rs

Part of rust-lang#121876.

Summary

This PR ports tests/run-make/extern-fn-reachable to use rmake.rs. Notable changes:

• We now use the object crate and look at the exported symbols specifically.
• This test's coverage regressed against windows-msvc back in replace dynamic library module with libloading rust-lang#90716, but since we use object now, we're able to claw the test coverage back.
• The checks are now stricter:
  1. It no longer looks for substring symbol matches in nm textual outputs, it inspects the symbol names precisely.
  2. We now also explicitly check for the presence of leading underscore in exported symbol names on apple vs non-apple targets.
• Added another case of #[no_mangle] fn fun6() {} (note the lack of pub) to check that Rust nameres visibility is orthogonal to symbol visibility in dylib.

History

• Test was initially introduced as a run-pass[^run-pass] test as part of Don't mark reachable extern fns as internal rust-lang#10539.
• Test re-introduced as a run-make test in rust-lang#13741.
• Later, the test coverage regressed in rust-lang#90716.

[^run-pass]: no longer a thing nowadays

Supersedes rust-lang#128314. Co-authored with @lolbinarycat.

try-job: x86_64-msvc try-job: i686-msvc try-job: i686-mingw try-job: x86_64-mingw-1 try-job: x86_64-apple-1 try-job: aarch64-apple try-job: test-various