Stablize anonymous pipe by NobodyXu · Pull Request #137793 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation37 Commits2 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Since #135822 is staled, I create this PR to stablise anonymous pipe
Closes #127154
try-job: test-various
This comment was marked as resolved.
Area: port run-make Makefiles to rmake.rs
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.
labels
This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.
cc @jieyouxu
The Miri subtree was changed
cc @rust-lang/miri
Rolling the original libs reviewer for the other stabilization attempt.
r? @joboet
Please squash the commits
Some changes occurred in src/tools/cargo
cc @ehuss
(Some unintentional submodule changes I think)
This comment has been minimized.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
The CI error is not related to any changes in this PR:
tidy error: could not find exception package `foldhash`
Stablise anonymous pipe Stablize anonymous pipe
#135822 also did some refactoring, are you also planning to put that up? If you do it in a separate PR feel free to request a review from me and we can probably merge it pretty quick.
If you do it in a separate PR feel free to request a review from me and we can probably merge it pretty quick.
Yes I want to put it in separate PR, I hope this PR can merge quick and hope that debian could pick it up, so that jobserver/etc can use it to reduce their burden
Reverted submodules changes, and tidy passed locally, so CI should be fixed now
cc @joboet this pr is ready for review
Can we get this PR merged please?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have the same request as in the original PR:
The changes here look good to me, though I'd like to see another change before stabilization:
Currently, things like the
Stdio: From<PipeWriter>implementations live insys::which IMHO is really confusing and dangerous (because people will forget to add these implementations when portingstd). Could you move all the public trait implementations toio::pipe(andos::_::pipefor the platform-specific implementations)?
I have fixed the error on wasm32-wasip1 by building for it locally
It would be great if someone can configure the CI to run the tests for that target to verify that
bors added a commit to rust-lang-ci/rust that referenced this pull request
☀️ Try build successful - checks-actions
Build commit: 639d746 (639d746f06b58f56711e3376dfa3e63104df8fc8)
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit 6863a99 has been approved by joshtriplett
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
still in the queue after being merged
@bors r-
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
thaliaarchi added a commit to thaliaarchi/rust that referenced this pull request
PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize
anonymous pipe), and rust-lang#136929 (std: move process implementations to
sys) merged around the same time, so update Trusty to take them into
account.
jhpratt added a commit to jhpratt/rust that referenced this pull request
…Poison,saethlin
Trusty: Fix build for anonymous pipes and std::sys::process
PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize anonymous pipe), and rust-lang#136929 (std: move process implementations to sys) merged around the same time, so update Trusty to take them into account.
cc @randomPoison
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#138875 - thaliaarchi:trusty-build, r=randomPoison,saethlin
Trusty: Fix build for anonymous pipes and std::sys::process
PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize anonymous pipe), and rust-lang#136929 (std: move process implementations to sys) merged around the same time, so update Trusty to take them into account.
cc @randomPoison
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request
…r=joshtriplett
Stablize anonymous pipe
Since rust-lang#135822 is staled, I create this PR to stablise anonymous pipe
Closes rust-lang#127154
try-job: test-various
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize
anonymous pipe), and rust-lang#136929 (std: move process implementations to
sys) merged around the same time, so update Trusty to take them into
account.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
…Poison,saethlin
Trusty: Fix build for anonymous pipes and std::sys::process
PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize anonymous pipe), and rust-lang#136929 (std: move process implementations to sys) merged around the same time, so update Trusty to take them into account.
cc @randomPoison
Labels
Area: port run-make Makefiles to rmake.rs
Operating system: Unix-like
Operating system: Windows
Status: This is awaiting some action (such as code changes or more information) from the author.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.