Implement read_buf for Hermit by thaliaarchi · Pull Request #138301 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
r? @tgross35
rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Operating System: Hermit
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
This was referenced
Mar 10, 2025
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! :)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two new unsafe blocks should get SAFETY comments, r=me after that
I've added SAFETY comments.
📌 Commit c5fc193 has been approved by tgross35
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
jhpratt added a commit to jhpratt/rust that referenced this pull request
…rmit, r=tgross35
Implement read_buf for Hermit
Following hermit-os/kernel#1606, it is now safe to implement Read::read_buf for file descriptors on Hermit.
cc @mkroening
jhpratt added a commit to jhpratt/rust that referenced this pull request
…rmit, r=tgross35
Implement read_buf for Hermit
Following hermit-os/kernel#1606, it is now safe to implement Read::read_buf for file descriptors on Hermit.
cc @mkroening
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#136320 (exit: document interaction with C)
- rust-lang#138080 (Leave a breadcrumb towards bootstrap config documentation in
bootstrap.toml) - rust-lang#138301 (Implement
read_buffor Hermit) - rust-lang#138569 (rustdoc-json: Add tests for
#[repr(...)]) - rust-lang#138635 (Extract
for_each_immediate_subpatfrom THIR pattern visitors) - rust-lang#138642 (Unvacation myself)
- rust-lang#138644 (Add
#[cfg(test)]for Transition in dfa inrustc_transmute)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#136320 (exit: document interaction with C)
- rust-lang#138080 (Leave a breadcrumb towards bootstrap config documentation in
bootstrap.toml) - rust-lang#138301 (Implement
read_buffor Hermit) - rust-lang#138569 (rustdoc-json: Add tests for
#[repr(...)]) - rust-lang#138635 (Extract
for_each_immediate_subpatfrom THIR pattern visitors) - rust-lang#138642 (Unvacation myself)
- rust-lang#138644 (Add
#[cfg(test)]for Transition in dfa inrustc_transmute)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#136320 (exit: document interaction with C)
- rust-lang#138080 (Leave a breadcrumb towards bootstrap config documentation in
bootstrap.toml) - rust-lang#138301 (Implement
read_buffor Hermit) - rust-lang#138569 (rustdoc-json: Add tests for
#[repr(...)]) - rust-lang#138635 (Extract
for_each_immediate_subpatfrom THIR pattern visitors) - rust-lang#138642 (Unvacation myself)
- rust-lang#138644 (Add
#[cfg(test)]for Transition in dfa inrustc_transmute)
r? @ghost
@rustbot modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
…rmit, r=tgross35
Implement read_buf for Hermit
Following hermit-os/kernel#1606, it is now safe to implement Read::read_buf for file descriptors on Hermit.
cc @mkroening
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#136320 (exit: document interaction with C)
- rust-lang#138080 (Leave a breadcrumb towards bootstrap config documentation in
bootstrap.toml) - rust-lang#138301 (Implement
read_buffor Hermit) - rust-lang#138569 (rustdoc-json: Add tests for
#[repr(...)]) - rust-lang#138635 (Extract
for_each_immediate_subpatfrom THIR pattern visitors) - rust-lang#138642 (Unvacation myself)
- rust-lang#138644 (Add
#[cfg(test)]for Transition in dfa inrustc_transmute)
r? @ghost
@rustbot modify labels: rollup
Labels
Operating System: Hermit
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.