Fix next solver handling of shallow trait impl check by oli-obk · Pull Request #138594 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits2 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

I'm trying to remove unnecessary direct calls to select, and this one seemed like a good place to start 😆

r? @compiler-errors or @lcnr

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment pls, this is a clever way to handle this in both solvers, but it took me a bit to think through it

r=me afterwards

thanks for fixing this 😊

r? lcnr

📌 Commit 14cd467 has been approved by lcnr

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 19, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 19, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#135394 (MaybeUninit inherent slice methods part 2)
• rust-lang#137051 (Implement default methods for io::Empty and io::Sink)
• rust-lang#138001 (mir_build: consider privacy when checking for irrefutable patterns)
• rust-lang#138540 (core/slice: Mark some split_off variants unstably const)
• rust-lang#138589 (If a label is placed on the block of a loop instead of the header, suggest moving it to the header.)
• rust-lang#138594 (Fix next solver handling of shallow trait impl check)
• rust-lang#138613 (Remove E0773 "A builtin-macro was defined more than once.")

Failed merges:

• rust-lang#138602 (Slim rustc_parse_format dependencies down)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 19, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#135394 (MaybeUninit inherent slice methods part 2)
• rust-lang#137051 (Implement default methods for io::Empty and io::Sink)
• rust-lang#138001 (mir_build: consider privacy when checking for irrefutable patterns)
• rust-lang#138540 (core/slice: Mark some split_off variants unstably const)
• rust-lang#138589 (If a label is placed on the block of a loop instead of the header, suggest moving it to the header.)
• rust-lang#138594 (Fix next solver handling of shallow trait impl check)
• rust-lang#138613 (Remove E0773 "A builtin-macro was defined more than once.")

Failed merges:

• rust-lang#138602 (Slim rustc_parse_format dependencies down)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 20, 2025

Rollup merge of rust-lang#138594 - oli-obk:no-select, r=lcnr

Fix next solver handling of shallow trait impl check

I'm trying to remove unnecessary direct calls to select, and this one seemed like a good place to start 😆

r? @compiler-errors or @lcnr

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.