Rollup of 9 pull requests by jieyouxu · Pull Request #138853 · rust-lang/rust (original) (raw)

Successful merges:

uefi: Add OwnedEvent abstraction #138236 (uefi: Add OwnedEvent abstraction)
rustdoc: Gate unstable doc(cfg()) predicates #138293 (rustdoc: Gate unstable doc(cfg()) predicates)
Add test to ensure no index out of bounds panic (#135474) #138509 (Add test to ensure no index out of bounds panic (ICE: demand: index out of bounds #135474))
Slim rustc_parse_format dependencies down #138602 (Slim rustc_parse_format dependencies down)
Update test for SGX now implementing read_buf #138631 (Update test for SGX now implementing read_buf)
Add unstable --print=supported-crate-types option #138641 (Add unstable --print=supported-crate-types option)
Implement some basics in UEFI fs #138662 (Implement some basics in UEFI fs)
resolve: Avoid remaining unstable iteration #138837 (resolve: Avoid remaining unstable iteration)
doc: rename reference #create-a-configtoml to #create-a-bootstraptoml #138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml)

Failed merges:

[rustdoc] Remove duplicated loop when computing doc cfgs #138755 ([rustdoc] Remove duplicated loop when computing doc cfgs)

r? @ghost
@rustbot modify labels: rollup

Events are going to become quite important for Networking, so needed owned abstractions.
Switch to OwnedEvent abstraction for Exit boot services event.

Signed-off-by: Ayush Singh ayush@beagleboard.org

In rust-lang#108326, read_buf was implemented for a variety of types, but SGX was saved for later. Update a test from then, now that rust-lang#137355 implemented it for SGX types.

Should be same as absolute in UEFI since there are no symlinks.
Also each absolute path representation should be unique according to the UEFI specification.

Signed-off-by: Ayush Singh ayush@beagleboard.org

UEFI does not have symlinks. So lstat and stat should behave the same.

Signed-off-by: Ayush Singh ayush@beagleboard.org

UEFI does not have specific modes for create_new, truncate and append. So those need to to be simulated after opening the file.

Signed-off-by: Ayush Singh ayush@beagleboard.org

As an unstable print request.

Document test intent to check for -Whelp suggestion if --print=lints was specified.
Move this test under tests/ui/print-request/ and rename it to print-lints-help.rs to better reflect what it is checking.

rustc_index is only used for its size assertion macro, so demote it to a dev-dependency gated under testing instead

uefi: Add OwnedEvent abstraction

Events are going to become quite important for Networking, so needed owned abstractions.
Switch to OwnedEvent abstraction for Exit boot services event.

cc @nicholasbishop

…eGomez

rustdoc: Gate unstable doc(cfg()) predicates

Fixes rust-lang#138113

Since the extraction process treats cfg(true) as having no cfg attribute, we have to do the gating during parsing; so we remove the unused features arg from Cfg::matches

…owLii

Slim rustc_parse_format dependencies down

rustc_index is only used for its size assertion macro, so demote it to a dev-dependency gated under testing instead. This allows the crate to built without having to wait for syn (pulled in by rustc_index_macros)

Alternatively we could inline the macro, though from the looks of it that will run into trouble with rustc_randomized_layouts

…orkingjubilee

Update test for SGX now implementing read_buf

In rust-lang#108326, read_buf was implemented for a variety of types, but SGX was saved for later. Update a test from then, now that rust-lang#137355 implemented it for SGX types.

cc @jethrogb

…es, r=Urgau

Add unstable --print=supported-crate-types option

MCP: rust-lang/compiler-team#836 Tracking issue: rust-lang#138640

Test coverage

Two tests:

tests/ui/print-request/stability.rs to check that --print=supported-crate-types is -Zunstable-options-gated
tests/ui/print-request/supported-crate-types.rs is added as a basic smoke test. Observe that the compiler stdout corresponds to the below Example output section (e.g. proc-macro is unsupported on wasm32-unknown-unknown currently).

Example output

For `x86_64-unknown-linux-gnu`

Notice the presence of {c,}dylib and proc-macro:

bin
cdylib
dylib
lib
proc-macro
rlib
staticlib

For `wasm32-unknown-unknown`

Notice the absence of dylib and proc-macro:

bin
cdylib
lib
rlib
staticlib

For `x86_64-unknown-linux-musl`

Notice the absence of {c,}dylib but presence of proc-macro:

bin
lib
proc-macro
rlib
staticlib

Documentation

I added an entry in the unstable book's print request section to document this supported-crate-types print request.

Unresolved questions

(Name bikeshedding) is supported-crate-types a good name for the print request? I'm inclined to say it's good enough for an unstable print request, but may be worth revisiting at stabilization time.

Stability

This print request being added is unstable in this PR. A separate stabilization PR following the usual compiler flag stabilization procedure should be filed for stabilization after some baking time.

Review remarks

Best reviewed commit-by-commit.

r? compiler

…hop,petrochenkov

Implement some basics in UEFI fs

Just getting some basics out of the way while waiting for rust-lang#138236 to be merged.
Adds fs::canonicalize. Should be same as absolute in case of UEFI since there is no symlink support and absolute path is guaranteed to be uniqe according to spec.
Make fs::lstat same as fs::stat. Should be same since UEFI does not have symlink support.
Implement OptionOptions.

cc @nicholasbishop @dvdhrm

resolve: Avoid remaining unstable iteration

Continuation of rust-lang#138580. This should be the performance sensitive part.

…nfigtoml, r=TaKO8Ki

doc: rename reference #create-a-configtoml to #create-a-bootstraptoml

rust-lang/rustc-dev-guide@e4ddc21 This commit renamed config.toml to bootstrap.toml.

rustbot added A-run-make