[rustdoc] Remove duplicated loop when computing doc cfgs by GuillaumeGomez · Pull Request #138755 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation11 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Status: Awaiting review from the assignee but also interested parties.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
Thanks! Should be able to take a look this weekend.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Nice find.
📌 Commit 9e6848b has been approved by camelid
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
FYI this probably merge-conflicts with #138293 (noticed in rollup #138853).
I'll rebase once merged then. ;)
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 10 pull requests
Successful merges:
- rust-lang#137593 (fix download-llvm logic for subtree sync branches)
- rust-lang#137736 (Don't attempt to export compiler-builtins symbols from rust dylibs)
- rust-lang#138135 (Simplify
PartialOrdon tuples containing primitives) - rust-lang#138321 ([bootstrap] Distribute split debuginfo if present)
- rust-lang#138574 (rustdoc: be more strict about "Methods from Deref")
- rust-lang#138606 (Fix missing rustfmt in msi installer - cont)
- rust-lang#138671 (Fix
FileTypePartialEqimplementation on Windows) - rust-lang#138728 (Update
compiler-builtinsto 0.1.152) - rust-lang#138783 (Cache current_dll_path output)
- rust-lang#138846 (Tweaks to writeback and
Obligation -> Goalconversion)
Failed merges:
- rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs)
r? @ghost
@rustbot modify labels: rollup
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
📌 Commit d9f250a has been approved by camelid
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
TaKO8Ki added a commit to TaKO8Ki/rust that referenced this pull request
… r=camelid
[rustdoc] Remove duplicated loop when computing doc cfgs
Working on implementing https://github.com/rust-lang/rfcs/blob/master/text/3631-rustdoc-cfgs-handling.md and found this weird case where the first loop was actually not doing anything since we were passing cfg(...) to Cfg::parse instead of cfg(...) items.
Well, that should be a first nice cleanup before the rest comes in.
cc @notriddle
r? @camelid
TaKO8Ki added a commit to TaKO8Ki/rust that referenced this pull request
… r=camelid
[rustdoc] Remove duplicated loop when computing doc cfgs
Working on implementing https://github.com/rust-lang/rfcs/blob/master/text/3631-rustdoc-cfgs-handling.md and found this weird case where the first loop was actually not doing anything since we were passing cfg(...) to Cfg::parse instead of cfg(...) items.
Well, that should be a first nice cleanup before the rest comes in.
cc @notriddle
r? @camelid
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#138755 - GuillaumeGomez:rm-duplicated-loop, r=camelid
[rustdoc] Remove duplicated loop when computing doc cfgs
Working on implementing https://github.com/rust-lang/rfcs/blob/master/text/3631-rustdoc-cfgs-handling.md and found this weird case where the first loop was actually not doing anything since we were passing cfg(...) to Cfg::parse instead of cfg(...) items.
Well, that should be a first nice cleanup before the rest comes in.
cc @notriddle
r? @camelid
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the rustdoc team, which will review and decide on the PR/issue.