remove intrinsics::drop_in_place by RalfJung · Pull Request #140151 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This was only ever accidentally stable, and has been marked as deprecated since Rust 1.52, released almost 4 years ago. We've removed the old serialization derives, maybe we can remove this one as well?
As suggested by @jhpratt, let's see what crater says for this one.
r? @thomcc
rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.
cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr
bors added a commit to rust-lang-ci/rust that referenced this pull request
…rinsic, r=
remove intrinsics::drop_in_place
This was only ever accidentally stable, and has been marked as deprecated since Rust 1.52, released almost 4 years ago. We've removed the old serialization derives, maybe we can remove this one as well?
As suggested by @jhpratt, let's see what crater says for this one.
This comment has been minimized.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…rinsic, r=
remove intrinsics::drop_in_place
This was only ever accidentally stable, and has been marked as deprecated since Rust 1.52, released almost 4 years ago. We've removed the old serialization derives, maybe we can remove this one as well?
As suggested by @jhpratt, let's see what crater says for this one.
This comment has been minimized.
More tests need blessing if we want to land this, but that doesn't block a crater run.
☀️ Try build successful - checks-actions
Build commit: 1bd50d4 (1bd50d4315eb15970d395b6be5823f9384707693)
🚧 Experiment pr-140151 is now running
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
all regressions look unrelated
Yeah, indeed.
So this becomes a question for @rust-lang/libs-api then I guess -- do we want to remove this accidentally-stable function that has been deprecated for years?
We discussed this in the @rust-lang/libs-api meeting and there was no opposition to removing it.
@rfcbot merge
This comment was marked as outdated.
Relevant to the library API team, which will review and decide on the PR/issue.
and removed proposed-final-comment-period
Proposed to merge/close by relevant subteam, see T- label. Will enter FCP once signed off.
This issue / PR is in PFCP or FCP with a disposition to merge it.
Relevant to the library team, which will review and decide on the PR/issue.
labels
This comment was marked as outdated.
This comment was marked as outdated.
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
Marks issues that should be documented in the release notes of the next release.
label
🔔 This is now entering its final comment period, as per the review above. 🔔
Labels
This issue / PR is in PFCP or FCP with a disposition to merge it.
In the final comment period and will be merged soon unless new substantive objections are raised.
Nominated for discussion during a libs-api team meeting.
Marks issues that should be documented in the release notes of the next release.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library API team, which will review and decide on the PR/issue.