bootstrap: Inhibit download-rustc in CI when tools are changed by Zalathar · Pull Request #140322 · rust-lang/rust (original) (raw)
Copy link
Contributor
•
edited
Loading
This automatically avoids situations like #139998 (comment) and #140177 (comment), where a sensitive change to compiletest was eligible for download-rustc, preventing the collection of proper test metrics for comparison.
While the primary goal is to make compiletest changes inhibit download-rustc, this PR ends up making any change to src/tools inhibit download-rustc (but only in CI builds). With the current code, it's not clear how to “un-exempt” individual subdirectories that are covered by another exemption.
See https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Should.20tool.20changes.20inhibit.20download-rustc.20on.20CI.3F for associated discussion.