Parser: Recover error from named params while parse_path by xizheyin · Pull Request #140671 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation38 Commits2 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Fixes #140169
I added test to the first commit and the second added the code and changes to test.
Signed-off-by: xizheyin xizheyin@smail.nju.edu.cn
rustbot added S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
rustbot added S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Reminder, once the PR becomes ready for a review, use @rustbot ready
.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rustbot added S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
xizheyin changed the title
Recover from Parser: Recover error from named params while parse_pathFn
, FnOnce
, FnMut
trait with named params
This comment has been minimized.
This comment has been minimized.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rustbot added S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
This comment has been minimized.
rustbot added S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
rustbot added S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
…ment`
Signed-off-by: xizheyin xizheyin@smail.nju.edu.cn
Co-authored-by: Vadim Petrochenkov vadim.petrochenkov@gmail.com
@rustbot ready
I revised the code and squashed the commits.
rustbot added S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit b922da3 has been approved by petrochenkov
It is now in the queue for this repository.
bors added S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 8 pull requests
Successful merges:
- rust-lang#140234 (Separate dataflow analysis and results)
- rust-lang#140614 (Correct warning message in restricted visibility)
- rust-lang#140671 (Parser: Recover error from named params while parse_path)
- rust-lang#140700 (Don't crash on error codes passed to
--explain
which exceed our internal limit of 9999 ) - rust-lang#140706 ([rustdoc] Ensure that temporary doctest folder is correctly removed even if doctests failed)
- rust-lang#140734 (Fix regression from rust-lang#140393 for espidf / horizon / nuttx / vita)
- rust-lang#140741 (add armv5te-unknown-linux-gnueabi target maintainer)
- rust-lang#140745 (run-make-support: set rustc dylib path for cargo wrapper)
r? @ghost
@rustbot
modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 8 pull requests
Successful merges:
- rust-lang#140234 (Separate dataflow analysis and results)
- rust-lang#140614 (Correct warning message in restricted visibility)
- rust-lang#140671 (Parser: Recover error from named params while parse_path)
- rust-lang#140700 (Don't crash on error codes passed to
--explain
which exceed our internal limit of 9999 ) - rust-lang#140706 ([rustdoc] Ensure that temporary doctest folder is correctly removed even if doctests failed)
- rust-lang#140734 (Fix regression from rust-lang#140393 for espidf / horizon / nuttx / vita)
- rust-lang#140741 (add armv5te-unknown-linux-gnueabi target maintainer)
- rust-lang#140745 (run-make-support: set rustc dylib path for cargo wrapper)
r? @ghost
@rustbot
modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#140671 - xizheyin:issue-140169, r=petrochenkov
Parser: Recover error from named params while parse_path
Fixes rust-lang#140169
I added test to the first commit and the second added the code and changes to test.
r? @petrochenkov
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.