Parser: Recover error from named params while parse_path by xizheyin · Pull Request #140671 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation38 Commits2 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

xizheyin

Fixes #140169

I added test to the first commit and the second added the code and changes to test.

r? @petrochenkov

@xizheyin

Signed-off-by: xizheyin xizheyin@smail.nju.edu.cn

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

May 5, 2025

@rust-log-analyzer

This comment has been minimized.

compiler-errors

@compiler-errors

@rustbot rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 5, 2025

@rustbot

Reminder, once the PR becomes ready for a review, use @rustbot ready.

xizheyin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

May 6, 2025

@xizheyin xizheyin changed the titleRecover from Fn, FnOnce, FnMut trait with named params Parser: Recover error from named params while parse_path

May 6, 2025

@rust-log-analyzer

This comment has been minimized.

petrochenkov

@rust-log-analyzer

This comment has been minimized.

xizheyin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

May 6, 2025

petrochenkov

@rust-log-analyzer

This comment has been minimized.

@xizheyin

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

May 6, 2025

compiler-errors

petrochenkov

@petrochenkov

@rustbot rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 7, 2025

@xizheyin @petrochenkov

…ment`

Signed-off-by: xizheyin xizheyin@smail.nju.edu.cn

Co-authored-by: Vadim Petrochenkov vadim.petrochenkov@gmail.com

@xizheyin

@rustbot ready

I revised the code and squashed the commits.

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

May 7, 2025

@petrochenkov

@bors

📌 Commit b922da3 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 7, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

May 7, 2025

@bors

…llaumeGomez

Rollup of 8 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

May 7, 2025

@bors

…llaumeGomez

Rollup of 8 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

May 8, 2025

@rust-timer

Rollup merge of rust-lang#140671 - xizheyin:issue-140169, r=petrochenkov

Parser: Recover error from named params while parse_path

Fixes rust-lang#140169

I added test to the first commit and the second added the code and changes to test.

r? @petrochenkov

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.