make `OsString::new` and `PathBuf::new` unstably const by cyrgani · Pull Request #141467 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Since #129041, String::into_bytes is const, which allows making OsString::new and PathBuf::new unstably const now.
Not sure what the exact process for this is; does it need an ACP?

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

May 23, 2025

Please create a tracking issue for this.

Hmm.

I don't see any ACPs, I think it just needs libs-api signoff

r? libs-api

rustbot added the T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.

label

May 30, 2025

📌 Commit fab206b has been approved by Amanieu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 3, 2025

bors added a commit that referenced this pull request

Jun 4, 2025

Rollup of 8 pull requests

Successful merges:

#136687 (Improve the documentation of Display and FromStr, and their interactions)
#137306 (Remove i128 and u128 from improper_ctypes_definitions)
#138699 (build dist for x86_64-pc-solaris and sparcv9-sun-solaris)
#141250 (add s390x z17 target features)
#141467 (make OsString::new and PathBuf::new unstably const)
#141871 (index: add method for checking range on DenseBitSet)
#141888 (Use non-2015 edition paths in tests that do not test for their resolution)
#142000 (bootstrap: don't symlink source dir into stage0 sysroot)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Jun 4, 2025

Rollup merge of #141467 - cyrgani:const-empty-stringlikes, r=Amanieu

make OsString::new and PathBuf::new unstably const

Since #129041, String::into_bytes is const, which allows making OsString::new and PathBuf::new unstably const now. Not sure what the exact process for this is; does it need an ACP?

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Jun 5, 2025

cyrgani deleted the const-empty-stringlikes branch

June 8, 2025 19:59

tautschnig pushed a commit to model-checking/verify-rust-std that referenced this pull request

Jun 17, 2025

…=Amanieu

make OsString::new and PathBuf::new unstably const

Since rust-lang#129041, String::into_bytes is const, which allows making OsString::new and PathBuf::new unstably const now. Not sure what the exact process for this is; does it need an ACP?

Labels

S-waiting-on-bors