use #[naked] for __rust_probestack by folkertdev · Pull Request #141992 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation19 Commits4 Checks9 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Let's see if this works now.
Previously this change was in rust-lang/compiler-builtins#897, but we decided to wait until compiler-builtins was a subtree (and also cfg(bootstrap) is gone now).
try-job: dist-various*
try-job: test-various*
Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins)
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Probestack naked function use #[naked] for __rust_probestack
It will most definitely work, in-tree compiler-builtins has no CI running and it is not yet used for anything :)
Me and my impatience...
Well, I'm happy to rebase this whenever to check whether things are working, and we'll see when everything is ready.
#141993 will be the main relevant PR here, plus hopefully having some kind of testing in-tree.
@rustbot blocked
Status: Blocked on something else such as an RFC or other implementation work.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
This comment has been minimized.
This comment has been minimized.
I'll kick off some jobs that should cover fortanix/sgx/uefi
@bors2 try
@bors2 delegate=try
⌛ Trying commit 601e479 with merge 98919d2…
To cancel the try build, run the command @bors2 try cancel.
@folkertdev can now perform try builds on this pull request
rust-bors bot added a commit that referenced this pull request
use #[naked] for __rust_probestack
Let's see if this works now.
Previously this change was in rust-lang/compiler-builtins#897, but we decided to wait until compiler-builtins was a subtree (and also cfg(bootstrap) is gone now).
r? @tgross35 cc @bjorn3
try-job: dist-various*
try-job: test-various*
Status: Awaiting review from the assignee but also interested parties.
and removed S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
labels
| // Our goal here is to touch each page between %rsp+8 and %rsp+8-%rax, |
|---|
| // ensuring that if any pages are unmapped we'll make a page fault. |
| // |
| // This function is unsafe because it uses a custom ABI, it does not actually match `extern "C"`. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind making these FIXME(extern_c) since that should be a thing soon?
☀️ Try build successful (CI)
Build commit: 98919d2 (98919d235b0bc249554b0ced4732020f6e247fe6)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, mind stuffing the last commit into the first?
✌️ @folkertdev, you can now approve this pull request!
If @tgross35 told you to "r=me" after making some further change, please make that change, then do @bors r=@tgross35
📌 Commit b030442 has been approved by tgross35
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
fmease added a commit to fmease/rust that referenced this pull request
…on, r=tgross35
use #[naked] for __rust_probestack
Let's see if this works now.
Previously this change was in rust-lang/compiler-builtins#897, but we decided to wait until compiler-builtins was a subtree (and also cfg(bootstrap) is gone now).
r? @tgross35 cc @bjorn3
try-job: dist-various*
try-job: test-various*
bors added a commit that referenced this pull request
Rollup of 14 pull requests
Successful merges:
- #134442 (Specify the behavior of
file!) - #134841 (Look at proc-macro attributes when encountering unknown attribute)
- #140372 (Exhaustively handle parsed attributes in CheckAttr)
- #140766 (Stabilize keylocker)
- #141642 (Note the version and PR of removed features when using it)
- #141909 (Add central execution context to bootstrap)
- #141992 (use
#[naked]for__rust_probestack) - #142102 (docs: Small clarification on the usage of read_to_string and read_to_end trait methods)
- #142124 (Allow transmute casts in pre-runtime-MIR)
- #142240 (deduplicate the rest of AST walker functions)
- #142258 (platform-support.md: Mention specific Linux kernel version or later)
- #142262 (Mark
core::slice::memchras#[doc(hidden)]) - #142271 (compiler: fn ptrs should hit different lints based on ABI)
- #142288 (const_eval: fix some outdated comments)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 16 pull requests
Successful merges:
- #134442 (Specify the behavior of
file!) - #140372 (Exhaustively handle parsed attributes in CheckAttr)
- #140766 (Stabilize keylocker)
- #141642 (Note the version and PR of removed features when using it)
- #141818 (Don't create .msi installer for gnullvm hosts)
- #141909 (Add central execution context to bootstrap)
- #141992 (use
#[naked]for__rust_probestack) - #142101 (core::ptr: deduplicate more method docs)
- #142102 (docs: Small clarification on the usage of read_to_string and read_to_end trait methods)
- #142124 (Allow transmute casts in pre-runtime-MIR)
- #142240 (deduplicate the rest of AST walker functions)
- #142258 (platform-support.md: Mention specific Linux kernel version or later)
- #142262 (Mark
core::slice::memchras#[doc(hidden)]) - #142271 (compiler: fn ptrs should hit different lints based on ABI)
- #142275 (rustdoc: Refractor
clean_ty_generics) - #142288 (const_eval: fix some outdated comments)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #141992 - folkertdev:probestack-naked-function, r=tgross35
use #[naked] for __rust_probestack
Let's see if this works now.
Previously this change was in rust-lang/compiler-builtins#897, but we decided to wait until compiler-builtins was a subtree (and also cfg(bootstrap) is gone now).
r? @tgross35 cc @bjorn3
try-job: dist-various*
try-job: test-various*
tgross35 pushed a commit to tgross35/compiler-builtins that referenced this pull request
tautschnig pushed a commit to model-checking/verify-rust-std that referenced this pull request
…on, r=tgross35
use #[naked] for __rust_probestack
Let's see if this works now.
Previously this change was in rust-lang/compiler-builtins#897, but we decided to wait until compiler-builtins was a subtree (and also cfg(bootstrap) is gone now).
r? @tgross35 cc @bjorn3
try-job: dist-various*
try-job: test-various*
Labels
Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins)
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.