tests/ui: A New Order [8/N] by Kivooeo · Pull Request #142200 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation41 Commits1 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.
r? @davidtwco
rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this and sorry for the delay. I have some feedback.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
⚠️ Warning ⚠️
- This PR is based on an upstream commit that is 15 days old.
It's recommended to update your branch according to the rustc-dev-guide.
@jieyouxu should i care about this warning above if there is no conflicts and im not touching anything compiler related?
This comment has been minimized.
wow, really? but how it works without explicit type
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
📌 Commit 7936070 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
SciMind2460 added a commit to SciMind2460/rust that referenced this pull request
tests/ui: A New Order [8/N]
Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of rust-lang#133895.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
tests/ui: A New Order [8/N]
Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of rust-lang#133895.
bors added a commit that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- #142146 (Withdraw the claim
extern "C-cmse-nonsecure-*"always matchesextern "C") - #142200 (
tests/ui: A New Order [8/N]) - #142724 (Add runtime check to avoid overwrite arg in
Diag) - #142809 (Add PrintTAFn flag for targeted type analysis printing)
- #142976 (Check CoerceUnsized impl validity before coercing)
- #142992 (Convert some ABI tests to use
extern "rust-invalid") - #143000 (Make
Sub,Mul,DivandRemconst_traits)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #142200 - Kivooeo:tf8, r=jieyouxu
tests/ui: A New Order [8/N]
Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.