Revert overeager warning for misuse of --print native-static-libs by workingjubilee · Pull Request #142595 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks9 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

In a PR to emit warnings on misuse of --print native-static-libs, we did not consider the matter of composing parts of build systems. If you are not directly invoking rustc, it can be difficult to know when you will in fact compile a staticlib, so making sure uses --print native-static-lib correctly can be just a nuisance.

Next cycle we can reland a slightly more narrowly focused variant or one that focuses on --emit instead of --print native-static-libs. But in its current state, I am not sure the warning is very useful.

Reverts #138139
Fixes #142582

r? @ChrisDenton

In a PR to emit warnings on misuse of --print native-static-libs, we did not consider the matter of composing parts of build systems. If you are not directly invoking rustc, it can be difficult to know when you will in fact compile a staticlib, so making sure everyone uses --print native-static-lib correctly can be just a nuisance.

This reverts the following commits:

• f66787a
• 72a9219
• 98bb597
• c59b708

Next cycle we can reland a slightly more narrowly focused variant or one that focuses on --emit instead of --print native-static-libs. But in its current state, I am not sure the warning is very useful.

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jun 16, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

I'd just note that the reverted PR is not really related to #137384 at all.

@bors r+ rollup

📌 Commit 7b29a5d has been approved by ChrisDenton

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 16, 2025

jhpratt added a commit to jhpratt/rust that referenced this pull request

Jun 17, 2025

…39, r=ChrisDenton

Revert overeager warning for misuse of --print native-static-libs

In a PR to emit warnings on misuse of --print native-static-libs, we did not consider the matter of composing parts of build systems. If you are not directly invoking rustc, it can be difficult to know when you will in fact compile a staticlib, so making sure uses --print native-static-lib correctly can be just a nuisance.

Next cycle we can reland a slightly more narrowly focused variant or one that focuses on --emit instead of --print native-static-libs. But in its current state, I am not sure the warning is very useful.

bors added a commit that referenced this pull request

Jun 17, 2025

Rollup of 11 pull requests

Successful merges:

• #140809 (Reduce special casing for the panic runtime)
• #141608 (Add support for repetition to proc_macro::quote)
• #141864 (Handle win32 separator for cygwin paths)
• #142216 (Miscellaneous RefCell cleanups)
• #142517 (Windows: Use anonymous pipes in Command)
• #142570 (Reject union default field values)
• #142584 (Handle same-crate macro for borrowck semicolon suggestion)
• #142585 (Update books)
• #142586 (Fold unnecessary visit_struct_field_def in AstValidator)
• #142595 (Revert overeager warning for misuse of --print native-static-libs)
• #142598 (Set elf e_flags on ppc64 targets according to abi)

r? @ghost @rustbot modify labels: rollup

rust-bors bot added a commit that referenced this pull request

Jun 17, 2025

Rollup of 13 pull requests

Successful merges:

• #138538 (Make performance description of String::{insert,insert_str,remove} more precise)
• #141946 (std: refactor explanation of NonNull)
• #142216 (Miscellaneous RefCell cleanups)
• #142542 (Manually invalidate caches in SimplifyCfg.)
• #142563 (Refine run-make test ignores due to unpredictable i686-pc-windows-gnu unwind mechanism)
• #142570 (Reject union default field values)
• #142584 (Handle same-crate macro for borrowck semicolon suggestion)
• #142585 (Update books)
• #142586 (Fold unnecessary visit_struct_field_def in AstValidator)
• #142587 (Make sure to propagate result from visit_expr_fields)
• #142595 (Revert overeager warning for misuse of --print native-static-libs)
• #142598 (Set elf e_flags on ppc64 targets according to abi)
• #142601 (Add a comment to FORMAT_VERSION.)

r? @ghost @rustbot modify labels: rollup

Create a similar rollup

try-job: dist-apple-various

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 17, 2025

…39, r=ChrisDenton

Revert overeager warning for misuse of --print native-static-libs

In a PR to emit warnings on misuse of --print native-static-libs, we did not consider the matter of composing parts of build systems. If you are not directly invoking rustc, it can be difficult to know when you will in fact compile a staticlib, so making sure uses --print native-static-lib correctly can be just a nuisance.

Next cycle we can reland a slightly more narrowly focused variant or one that focuses on --emit instead of --print native-static-libs. But in its current state, I am not sure the warning is very useful.

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jun 17, 2025

…39, r=ChrisDenton

Revert overeager warning for misuse of --print native-static-libs

In a PR to emit warnings on misuse of --print native-static-libs, we did not consider the matter of composing parts of build systems. If you are not directly invoking rustc, it can be difficult to know when you will in fact compile a staticlib, so making sure uses --print native-static-lib correctly can be just a nuisance.

Next cycle we can reland a slightly more narrowly focused variant or one that focuses on --emit instead of --print native-static-libs. But in its current state, I am not sure the warning is very useful.

bors added a commit that referenced this pull request

Jun 17, 2025

Rollup of 7 pull requests

Successful merges:

• #141061 (Change __rust_no_alloc_shim_is_unstable to be a function)
• #142585 (Update books)
• #142586 (Fold unnecessary visit_struct_field_def in AstValidator)
• #142587 (Make sure to propagate result from visit_expr_fields)
• #142595 (Revert overeager warning for misuse of --print native-static-libs)
• #142598 (Set elf e_flags on ppc64 targets according to abi)
• #142601 (Add a comment to FORMAT_VERSION.)

r? @ghost @rustbot modify labels: rollup

rust-bors bot added a commit that referenced this pull request

Jun 17, 2025

Rollup of 7 pull requests

Successful merges:

• #141061 (Change __rust_no_alloc_shim_is_unstable to be a function)
• #142585 (Update books)
• #142586 (Fold unnecessary visit_struct_field_def in AstValidator)
• #142587 (Make sure to propagate result from visit_expr_fields)
• #142595 (Revert overeager warning for misuse of --print native-static-libs)
• #142598 (Set elf e_flags on ppc64 targets according to abi)
• #142601 (Add a comment to FORMAT_VERSION.)

r? @ghost @rustbot modify labels: rollup

Create a similar rollup

try-job: x86_64-gnu-aux

bors added a commit that referenced this pull request

Jun 17, 2025

Rollup of 13 pull requests

Successful merges:

• #138538 (Make performance description of String::{insert,insert_str,remove} more precise)
• #141946 (std: refactor explanation of NonNull)
• #142216 (Miscellaneous RefCell cleanups)
• #142542 (Manually invalidate caches in SimplifyCfg.)
• #142563 (Refine run-make test ignores due to unpredictable i686-pc-windows-gnu unwind mechanism)
• #142570 (Reject union default field values)
• #142584 (Handle same-crate macro for borrowck semicolon suggestion)
• #142585 (Update books)
• #142586 (Fold unnecessary visit_struct_field_def in AstValidator)
• #142587 (Make sure to propagate result from visit_expr_fields)
• #142595 (Revert overeager warning for misuse of --print native-static-libs)
• #142598 (Set elf e_flags on ppc64 targets according to abi)
• #142601 (Add a comment to FORMAT_VERSION.)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Jun 17, 2025

Rollup merge of #142595 - workingjubilee:revert-warning-138139, r=ChrisDenton

Revert overeager warning for misuse of --print native-static-libs

In a PR to emit warnings on misuse of --print native-static-libs, we did not consider the matter of composing parts of build systems. If you are not directly invoking rustc, it can be difficult to know when you will in fact compile a staticlib, so making sure uses --print native-static-lib correctly can be just a nuisance.

Next cycle we can reland a slightly more narrowly focused variant or one that focuses on --emit instead of --print native-static-libs. But in its current state, I am not sure the warning is very useful.

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Jun 18, 2025

github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request

Jun 24, 2025

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.