Stats output tweaks by nnethercote · Pull Request #142944 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits3 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Some improvements to -Zinput-stats and -Zmeta-stat inspired by the new -Zmacro-stats.
r? @lqd
Taking inspiration from -Zmacro-stats:
- Use "{prefix}" consistently.
- Use names for column widths.
- Write output in a single
eprint!call, in an attempt to minimize interleaving of output from different rustc processes. - Use
repeatfor the long---banners.
Currently they have the largest items at the end. I believe the rationale is that it saves you scrolling up through terminal output because the important stuff is at the bottom. But it's also surprising and a bit confusing, and I think the obvious order (big things at the top) is better.
To make it match -Zmacro-stats, and work better if you have enabled it
for multiple crates.
- Print each crate's name.
- Print a
===banner at the start and end for separation.
rustbot added S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit b2a57e6 has been approved by lqd
It is now in the queue for this repository.
bors added S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- #137268 (Allow comparisons between
CStr,CString, andCow<CStr>.) - #142704 (Remove the deprecated unstable
concat_idents!macro) - #142742 ([win][aarch64] Fix linking statics on Arm64EC, take 2)
- #142843 (Enable reproducible-build-2 for Windows MSVC)
- #142916 (rustdoc-json: Add test for
#[optimize(..)]) - #142919 (rustdoc-json: Add test for
#[cold]) - #142944 (Stats output tweaks)
Failed merges:
- #142825 (Port
#[track_caller]to the new attribute system)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #142944 - nnethercote:stats-tweaks, r=lqd
Stats output tweaks
Some improvements to -Zinput-stats and -Zmeta-stat inspired by the new -Zmacro-stats.
r? @lqd
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.