hir_analysis: prohibit dyn PointeeSized by davidtwco · Pull Request #143104 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation17 Commits1 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Fixes #142652
Supersedes #142663
dyn PointeeSized is nonsensical as a dyn PointeeSized needs to be MetaSized, so lets reject it to avoid hitting code paths that expect a builtin impl for PointeeSized
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
HIR ty lowering was modified
cc @fmease
This is gonna fail tidy b/c you're not supposed to name tests issue-###-....
This comment was marked as resolved.
This comment has been minimized.
📌 Commit 50d7735 has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
@bors r-
Please consider installing that tidy commit hook lol, or at least manually checking tidy before you push
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Please consider installing that tidy commit hook lol, or at least manually checking tidy before you push
I normally do, was just careless at the end of the work day.
@bors r=compiler-errors rollup
📌 Commit 2057423 has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
bors added a commit that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- #139858 (New const traits syntax)
- #140809 (Reduce special casing for the panic runtime)
- #142730 (suggest declaring modules when file found but module not defined)
- #142806 (Normalize before computing ConstArgHasType goal in new solver)
- #143046 (const validation: properly ignore zero-sized UnsafeCell)
- #143092 (const checks for lifetime-extended temporaries: avoid 'top-level scope' terminology)
- #143096 (tag_for_variant: properly pass TypingEnv)
- #143104 (hir_analysis: prohibit
dyn PointeeSized) - #143106 (gce: don't ICE on non-local const)
Failed merges:
- #143036 (Remove support for
dyn*from the compiler)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #143104 - davidtwco:issue-142652-dyn-pointeesized-deny, r=compiler-errors
hir_analysis: prohibit dyn PointeeSized
Fixes #142652 Supersedes #142663
dyn PointeeSized is nonsensical as a dyn PointeeSized needs to be MetaSized, so lets reject it to avoid hitting code paths that expect a builtin impl for PointeeSized
r? @compiler-errors
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request
This was referenced
Jul 24, 2025
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.