Use the correct export kind for __rust_alloc_error_handler_should_panic by dpaoliello · Pull Request #143260 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks10 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Fixes #143253

__rust_alloc_error_handler_should_panic is a static but was being exported as a function.

For most targets this doesn't matter, but Arm64EC Windows uses different decorations for exported variables vs functions, hence it fails to link when -Z oom=abort is enabled.

Fix is to export the symbol as data.

r? @bjorn3

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jun 30, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

📌 Commit c073286 has been approved by bjorn3

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jul 1, 2025

jhpratt added a commit to jhpratt/rust that referenced this pull request

Jul 1, 2025

Use the correct export kind for __rust_alloc_error_handler_should_panic

Fixes rust-lang#143253

__rust_alloc_error_handler_should_panic is a static but was being exported as a function.

For most targets this doesn't matter, but Arm64EC Windows uses different decorations for exported variables vs functions, hence it fails to link when -Z oom=abort is enabled.

Fix is to export the symbol as data.

r? @bjorn3

bors added a commit that referenced this pull request

Jul 2, 2025

Rollup of 12 pull requests

Successful merges:

• #141829 (Specialize sleep_until implementation for unix (except mac))
• #141847 (Explain TOCTOU on the top of std::fs, and reference it in functions)
• #142138 (Add Vec::into_chunks)
• #142321 (Expose elf abi on ppc64 targets)
• #142568 (Use the .drectve section for exporting symbols from dlls on Windows)
• #142886 (ci: aarch64-gnu: Stop skipping panic_abort_doc_tests)
• #143038 (avoid suggesting traits from private dependencies)
• #143194 (fix bitcast of single-element SIMD vectors)
• #143206 (Align attr fixes)
• #143258 (Don't recompute DisambiguatorState for every RPITIT in trait definition)
• #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
• #143274 (ci: support optional jobs)

r? @ghost @rustbot modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request

Jul 2, 2025

Use the correct export kind for __rust_alloc_error_handler_should_panic

Fixes rust-lang#143253

__rust_alloc_error_handler_should_panic is a static but was being exported as a function.

For most targets this doesn't matter, but Arm64EC Windows uses different decorations for exported variables vs functions, hence it fails to link when -Z oom=abort is enabled.

Fix is to export the symbol as data.

r? @bjorn3

bors added a commit that referenced this pull request

Jul 2, 2025

Rollup of 11 pull requests

Successful merges:

• #141829 (Specialize sleep_until implementation for unix (except mac))
• #141847 (Explain TOCTOU on the top of std::fs, and reference it in functions)
• #142138 (Add Vec::into_chunks)
• #142321 (Expose elf abi on ppc64 targets)
• #142886 (ci: aarch64-gnu: Stop skipping panic_abort_doc_tests)
• #143038 (avoid suggesting traits from private dependencies)
• #143194 (fix bitcast of single-element SIMD vectors)
• #143206 (Align attr fixes)
• #143258 (Don't recompute DisambiguatorState for every RPITIT in trait definition)
• #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
• #143274 (ci: support optional jobs)

r? @ghost @rustbot modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request

Jul 2, 2025

Use the correct export kind for __rust_alloc_error_handler_should_panic

Fixes rust-lang#143253

__rust_alloc_error_handler_should_panic is a static but was being exported as a function.

For most targets this doesn't matter, but Arm64EC Windows uses different decorations for exported variables vs functions, hence it fails to link when -Z oom=abort is enabled.

Fix is to export the symbol as data.

r? @bjorn3

bors added a commit that referenced this pull request

Jul 2, 2025

Rollup of 12 pull requests

Successful merges:

• #141847 (Explain TOCTOU on the top of std::fs, and reference it in functions)
• #142138 (Add Vec::into_chunks)
• #142321 (Expose elf abi on ppc64 targets)
• #142886 (ci: aarch64-gnu: Stop skipping panic_abort_doc_tests)
• #143038 (avoid suggesting traits from private dependencies)
• #143194 (fix bitcast of single-element SIMD vectors)
• #143206 (Align attr fixes)
• #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
• #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
• #143258 (Don't recompute DisambiguatorState for every RPITIT in trait definition)
• #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
• #143274 (ci: support optional jobs)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jul 2, 2025

Use the correct export kind for __rust_alloc_error_handler_should_panic

Fixes rust-lang#143253

__rust_alloc_error_handler_should_panic is a static but was being exported as a function.

For most targets this doesn't matter, but Arm64EC Windows uses different decorations for exported variables vs functions, hence it fails to link when -Z oom=abort is enabled.

Fix is to export the symbol as data.

r? @bjorn3

bors added a commit that referenced this pull request

Jul 2, 2025

Rollup of 11 pull requests

Successful merges:

• #141847 (Explain TOCTOU on the top of std::fs, and reference it in functions)
• #142138 (Add Vec::into_chunks)
• #142321 (Expose elf abi on ppc64 targets)
• #142886 (ci: aarch64-gnu: Stop skipping panic_abort_doc_tests)
• #143038 (avoid suggesting traits from private dependencies)
• #143194 (fix bitcast of single-element SIMD vectors)
• #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
• #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
• #143258 (Don't recompute DisambiguatorState for every RPITIT in trait definition)
• #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
• #143274 (ci: support optional jobs)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jul 2, 2025

Use the correct export kind for __rust_alloc_error_handler_should_panic

Fixes rust-lang#143253

__rust_alloc_error_handler_should_panic is a static but was being exported as a function.

For most targets this doesn't matter, but Arm64EC Windows uses different decorations for exported variables vs functions, hence it fails to link when -Z oom=abort is enabled.

Fix is to export the symbol as data.

r? @bjorn3

bors added a commit that referenced this pull request

Jul 2, 2025

Rollup of 10 pull requests

Successful merges:

• #141847 (Explain TOCTOU on the top of std::fs, and reference it in functions)
• #142138 (Add Vec::into_chunks)
• #142321 (Expose elf abi on ppc64 targets)
• #142886 (ci: aarch64-gnu: Stop skipping panic_abort_doc_tests)
• #143194 (fix bitcast of single-element SIMD vectors)
• #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
• #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
• #143258 (Don't recompute DisambiguatorState for every RPITIT in trait definition)
• #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
• #143274 (ci: support optional jobs)

r? @ghost @rustbot modify labels: rollup

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Jul 2, 2025

I'm going to switch approaches and convert __rust_alloc_error_handler_should_panic to be a function instead.

Labels

S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.