Don't require eh_personality lang item on targets that have a personality by ChrisDenton · Pull Request #143893 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
MSVC and wasm have personalities of their own so Rust's personality function is never called. The removed library comment has some more details.
Some targets already have personality
r? @jhpratt
rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.
labels
This is a bit of both compiler and libs but I think it's more compiler (as the libs changes trivially follow from the compiler ones) so...
r? compiler
r? compiler-errors @bors r+ rollup
📌 Commit 98eadb3 has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
fmease added a commit to fmease/rust that referenced this pull request
…l, r=compiler-errors
Don't require eh_personality lang item on targets that have a personality
MSVC and wasm have personalities of their own so Rust's personality function is never called. The removed library comment has some more details.
bors added a commit that referenced this pull request
Rollup of 16 pull requests
Successful merges:
- #142885 (core: Add
BorrowedCursor::with_unfilled_buf) - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure)
- #143355 (wrapping shift: remove first bitmask and table)
- #143448 (remote-test-client: Exit code
128 + <signal-number>instead of3) - #143592 (UWP: link ntdll functions using raw-dylib)
- #143681 (bootstrap/miri: avoid rebuilds for test builds)
- #143710 (Updates to random number generation APIs)
- #143724 (Tidy cleanup)
- #143820 (Fixed a core crate compilation failure when enabling the
optimize_for_sizefeature on some targets) - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling)
- #143855 (Port
#[omit_gdb_pretty_printer_section]to the new attribute parsing) - #143868 (warn on align on fields to avoid breaking changes)
- #143875 (update issue number for
const_trait_impl) - #143881 (Use zero for initialized Once state)
- #143887 (Run bootstrap tests sooner in the
x testpipeline) - #143893 (Don't require
eh_personalitylang item on targets that have a personality)
Failed merges:
- #143878 (Port
#[pointee]to the new attribute parsing infrastructure) - #143891 (Port
#[coverage]to the new attribute system)
r? @ghost
@rustbot modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request
…l, r=compiler-errors
Don't require eh_personality lang item on targets that have a personality
MSVC and wasm have personalities of their own so Rust's personality function is never called. The removed library comment has some more details.
bors added a commit that referenced this pull request
Rollup of 17 pull requests
Successful merges:
- #142885 (core: Add
BorrowedCursor::with_unfilled_buf) - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure)
- #143355 (wrapping shift: remove first bitmask and table)
- #143448 (remote-test-client: Exit code
128 + <signal-number>instead of3) - #143681 (bootstrap/miri: avoid rebuilds for test builds)
- #143710 (Updates to random number generation APIs)
- #143724 (Tidy cleanup)
- #143738 (Move several float tests to floats/mod.rs)
- #143820 (Fixed a core crate compilation failure when enabling the
optimize_for_sizefeature on some targets) - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling)
- #143855 (Port
#[omit_gdb_pretty_printer_section]to the new attribute parsing) - #143868 (warn on align on fields to avoid breaking changes)
- #143875 (update issue number for
const_trait_impl) - #143881 (Use zero for initialized Once state)
- #143887 (Run bootstrap tests sooner in the
x testpipeline) - #143893 (Don't require
eh_personalitylang item on targets that have a personality) - #143901 (Region constraint nits)
Failed merges:
- #143878 (Port
#[pointee]to the new attribute parsing infrastructure) - #143891 (Port
#[coverage]to the new attribute system)
r? @ghost
@rustbot modify labels: rollup
Could this have caused the rollup failure (#143916) on aaarch64-pc-windows-msvc?
error: #[panic_handler] function required, but not found
error: aborting due to 1 previous error
failures: [ui] tests\ui\extern-flag\empty-extern-arg.rs [ui] tests\ui\extern-flag\no-force-extern.rs [ui] tests\ui\no_std\no-std-unwind-binary.rs [ui] tests\ui\panic-handler\weak-lang-item.rs [ui] tests\ui\proc-macro\issue-59191-replace-root-with-fn.rs
@bors r-
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
I wasn't 100% certain either, but this is the only one that seems even remotely related to the error output changing.
Labels
Status: This is awaiting some action (such as code changes or more information) from the author.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.