Enable outline-atomics for aarch64-unknown-linux-musl by Gelbpunkt · Pull Request #144429 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
They were disabled in bd287fa and haven't been causing problems for a while anymore, see #89626 for details.
The entire testsuite still passes on aarch64-unknown-linux-musl with this feature enabled.
They were disabled in bd287fa and haven't been causing problems for a while anymore.
The entire testsuite still passes on aarch64-unknown-linux-musl with this feature enabled.
Signed-off-by: Jens Reidel adrian@travitia.xyz
r? @SparrowLii
rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit 3d0dedd has been approved by Amanieu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
jhpratt added a commit to jhpratt/rust that referenced this pull request
…musl, r=Amanieu
Enable outline-atomics for aarch64-unknown-linux-musl
They were disabled in bd287fa and haven't been causing problems for a while anymore, see rust-lang#89626 for details.
The entire testsuite still passes on aarch64-unknown-linux-musl with this feature enabled.
bors added a commit that referenced this pull request
Rollup of 13 pull requests
Successful merges:
- #144359 (add codegen test for variadics)
- #144379 (test using multiple c-variadic ABIs in the same program)
- #144383 (disable cfg.has_reliable_f128 on amdgcn)
- #144409 (Stop compilation early if macro expansion failed)
- #144422 (library/windows_targets: Fix macro expansion error in 'link' macro)
- #144429 (Enable outline-atomics for aarch64-unknown-linux-musl)
- #144430 (tests: aarch64-outline-atomics: Remove hardcoded target)
- #144445 (Fix
./x check bootstrap(again)) - #144453 (canonicalize build root in
tests/run-make/linker-warning) - #144464 (Only run bootstrap tests in
x teston CI) - #144470 (clif: Don't set the
compiler-builtins-no-f16-f128feature) - #144480 (Revert "coverage: Enlarge empty spans during MIR instrumentation, not codegen")
- #144495 (bump cargo_metadata)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 13 pull requests
Successful merges:
- #141840 (If
HOMEis empty, use the fallback instead) - #144359 (add codegen test for variadics)
- #144379 (test using multiple c-variadic ABIs in the same program)
- #144383 (disable cfg.has_reliable_f128 on amdgcn)
- #144409 (Stop compilation early if macro expansion failed)
- #144422 (library/windows_targets: Fix macro expansion error in 'link' macro)
- #144429 (Enable outline-atomics for aarch64-unknown-linux-musl)
- #144430 (tests: aarch64-outline-atomics: Remove hardcoded target)
- #144445 (Fix
./x check bootstrap(again)) - #144453 (canonicalize build root in
tests/run-make/linker-warning) - #144464 (Only run bootstrap tests in
x teston CI) - #144470 (clif: Don't set the
compiler-builtins-no-f16-f128feature) - #144480 (Revert "coverage: Enlarge empty spans during MIR instrumentation, not codegen")
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #144429 - Gelbpunkt:outline-atomics-aarch64-musl, r=Amanieu
Enable outline-atomics for aarch64-unknown-linux-musl
They were disabled in bd287fa and haven't been causing problems for a while anymore, see #89626 for details.
The entire testsuite still passes on aarch64-unknown-linux-musl with this feature enabled.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.