Rename begin_panic to panic_with_payload by Kivooeo · Pull Request #144902 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation13 Commits1 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the Clippy team.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.
labels
Some changes occurred to the CTFE machinery
This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.
Some changes occurred to constck
cc @fee1-dead
Some changes occurred in src/tools/clippy
cc @rust-lang/clippy
This comment has been minimized.
This comment has been minimized.
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.
cc @rust-lang/rust-analyzer
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.
cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang
According to message above would it be reasonable to move rust-analyzer changes into it's repo? or it's fine like this
This comment has been minimized.
Relevant to the release subteam, which will review and decide on the PR/issue.
label
| //! features, such as Fn family of traits. |
|---|
| use hir_expand:📛:Name; |
| use intern::{Symbol, sym}; |
| use intern::{sym, Symbol}; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we're reformatting rust-analyzer code? That probably should not be made in rust-lang/rust, and instead left for upstream PR(s). Making the necessary 1-line change here seems reasonable though.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I've asked about it above, thanks for an answer confirming it, but I will take some actions after we settle on naming, because currently according to a zullip topic we don't have consensus
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Labels
Area: rustc-dev-guide
Status: This is awaiting some action (such as code changes or more information) from the author.
Relevant to the Clippy team.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.
Relevant to the release subteam, which will review and decide on the PR/issue.