Visit and print async_fut local for async drop. by cjgillot · Pull Request #145510 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This is a bugfix for a MIR local we forget to visit.
I had a lot of trouble reading the docs for async_fut, so I'm not certain about the change to the pretty-printer.
rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit f35d001 has been approved by davidtwco
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
jhpratt added a commit to jhpratt/rust that referenced this pull request
…twco
Visit and print async_fut local for async drop.
This is a bugfix for a MIR local we forget to visit.
I had a lot of trouble reading the docs for async_fut, so I'm not certain about the change to the pretty-printer.
jhpratt added a commit to jhpratt/rust that referenced this pull request
…twco
Visit and print async_fut local for async drop.
This is a bugfix for a MIR local we forget to visit.
I had a lot of trouble reading the docs for async_fut, so I'm not certain about the change to the pretty-printer.
bors added a commit that referenced this pull request
Rollup of 33 pull requests
Successful merges:
- #139345 (Extend
QueryStabilityto handleIntoIteratorimplementations) - #140740 (Add
-Zindirect-branch-cs-prefix) - #142079 (nll-relate: improve hr opaque types support)
- #142938 (implement std::fs::set_permissions_nofollow on unix)
- #144767 (Correct some grammar in integer documentation)
- #144906 (Require approval from t-infra instead of t-release on tier bumps)
- #144983 (Rehome 37
tests/ui/issues/tests to other subdirectories undertests/ui/) - #145025 (run spellcheck as a tidy extra check in ci)
- #145166 (suggest using
pub(crate)for E0364) - #145255 (dec2flt: Provide more valid inputs examples)
- #145306 (Add tracing to various miscellaneous functions)
- #145336 (Hide docs for
core::unicode) - #145429 (Couple of codegen_fn_attrs improvements)
- #145452 (Do not strip binaries in bootstrap everytime if they are unchanged)
- #145464 (Stabilize
const_pathbuf_osstring_newfeature) - #145474 (Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups)
- #145486 (Fix
unicode_data.rsmention message) - #145493 (remove
should_renderinPrintAttributederive) - #145505 (Simplify span caches)
- #145510 (Visit and print async_fut local for async drop.)
- #145511 (Rust build fails on OpenBSD after using file_lock feature)
- #145532 (resolve: debug for block module)
- #145533 (Reorder
ltooptions from most to least optimizing) - #145537 (Do not consider a
T: !Sizedcandidate to satisfy aT: !MetaSizedobligation.) - #145538 (bufreader::Buffer::backshift: don't move the uninit bytes)
- #145542 (triagebot: Don't warn no-mentions on subtree updates)
- #145549 (Update rust maintainers in openharmony.md)
- #145550 (Avoid using
()inderive(From)output.) - #145556 (Allow stability attributes on extern crates)
- #145560 (Remove unused
PartialOrd/Ordfrom bootstrap) - #145568 (ignore frontmatters in
TokenStream::new) - #145571 (remove myself from some adhoc-groups and pings)
- #145576 (Add change tracker entry for
--timings)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 15 pull requests
Successful merges:
- #145338 (actually provide the correct args to coroutine witnesses)
- #145429 (Couple of codegen_fn_attrs improvements)
- #145452 (Do not strip binaries in bootstrap everytime if they are unchanged)
- #145464 (Stabilize
const_pathbuf_osstring_newfeature) - #145474 (Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups)
- #145486 (Fix
unicode_data.rsmention message) - #145490 (Trace some basic I/O operations in bootstrap)
- #145493 (remove
should_renderinPrintAttributederive) - #145500 (Port must_use to the new target checking)
- #145505 (Simplify span caches)
- #145510 (Visit and print async_fut local for async drop.)
- #145511 (Rust build fails on OpenBSD after using file_lock feature)
- #145532 (resolve: debug for block module)
- #145533 (Reorder
ltooptions from most to least optimizing) - #145537 (Do not consider a
T: !Sizedcandidate to satisfy aT: !MetaSizedobligation.)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #145510 - cjgillot:visit-async-drop, r=davidtwco
Visit and print async_fut local for async drop.
This is a bugfix for a MIR local we forget to visit.
I had a lot of trouble reading the docs for async_fut, so I'm not certain about the change to the pretty-printer.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.