fix(lexer): Don't require frontmatters to be escaped with indented fences by epage · Pull Request #145754 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The RFC only limits hyphens at the beginning of lines and not if they are indented or embedded in other content.
Sticking to that approach was confirmed by the T-lang liason at #141367 (comment)
There is a regression in error message quality which I'm leaving for someone if they feel this needs improving.
Tracking issue: #136889
Fixes #141367
r? @SparrowLii
rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
14 tasks
This comment has been minimized.
…nces
The RFC only limits hyphens at the beginning of lines and not if they are indented or embedded in other content.
Sticking to that approach was confirmed by the T-lang liason at rust-lang#141367 (comment)
There is a regression in error message quality which I'm leaving for someone if they feel this needs improving.
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📌 Commit 142e25e has been approved by SparrowLii
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit that referenced this pull request
Rollup of 5 pull requests
Successful merges:
- #145468 (dedup recip, powi, to_degrees, and to_radians float tests)
- #145643 (coverage: Build an "expansion tree" and use it to unexpand raw spans)
- #145754 (fix(lexer): Don't require frontmatters to be escaped with indented fences)
- #146060 (fixup nix dev shell again)
- #146068 (compiletest: Capture panic messages via a custom panic hook)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #145754 - epage:escape, r=SparrowLii
fix(lexer): Don't require frontmatters to be escaped with indented fences
The RFC only limits hyphens at the beginning of lines and not if they are indented or embedded in other content.
Sticking to that approach was confirmed by the T-lang liason at #141367 (comment)
There is a regression in error message quality which I'm leaving for someone if they feel this needs improving.
Tracking issue: #136889
Fixes #141367
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
Rollup of 5 pull requests
Successful merges:
- rust-lang#145468 (dedup recip, powi, to_degrees, and to_radians float tests)
- rust-lang#145643 (coverage: Build an "expansion tree" and use it to unexpand raw spans)
- rust-lang#145754 (fix(lexer): Don't require frontmatters to be escaped with indented fences)
- rust-lang#146060 (fixup nix dev shell again)
- rust-lang#146068 (compiletest: Capture panic messages via a custom panic hook)
r? @ghost
@rustbot modify labels: rollup
11 tasks
10 tasks
Labels
`#![feature(frontmatter)]`
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.