ci: x86_64-gnu-tools: Add --test-args regression test by Enselic · Pull Request #146606 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits1 Checks10 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Area: Our Github Actions CI
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
This comment has been minimized.
ci: x86_64-gnu-tools: Add ad-hoc --test-args regression test ci: x86_64-gnu-tools: Add --test-args regression test
This comment has been minimized.
This comment has been minimized.
The test run was without the fix. So the test catches the bug, because the test fails without the fix. From the log:
2025-09-16T07:00:10.3144326Z ERROR: --test-args functionality is broken
2025-09-16T07:00:10.3144887Z + echo ERROR: --test-args functionality is broken
2025-09-16T07:00:10.3145317Z + exit 1
I will now rebase on master which has the fix. So if the test then passes, we know the test works as intended.
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
The test passed after rebasing on the fix. So the test works and would have caught the bug (and will prevent regressions).
@rustbot ready
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
| # Any test can be used. We arbitrarily chose `tests/ui/lint/unused/unused-result.rs`. |
|---|
| python3 "$X_PY" test tests/ui --test-args tests/ui/lint/unused/unused-result.rs --force-rerun | |
| grep --fixed-strings 'test result: ok. 1 passed; 0 failed; 0 ignored;' | |
| ( echo "ERROR: --test-args functionality is broken" && exit 1 ) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I was thinking of more of a unit test directly in compiletest, but I think this seems OK too.
📌 Commit 91cf067 has been approved by Mark-Simulacrum
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
This was referenced
Sep 21, 2025
bors added a commit that referenced this pull request
Rollup of 4 pull requests
Successful merges:
- #143857 (Port #[macro_export] to the new attribute parsing infrastructure)
- #146486 (Improve
core::sync::atomiccoverage) - #146606 (ci: x86_64-gnu-tools: Add
--test-argsregression test) - #146639 (std: merge definitions of
StdioPipes)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #146606 - Enselic:test-test-args, r=Mark-Simulacrum
ci: x86_64-gnu-tools: Add --test-args regression test
r? @Mark-Simulacrum
Muscraft pushed a commit to Muscraft/rust that referenced this pull request
Muscraft pushed a commit to Muscraft/rust that referenced this pull request
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#143857 (Port #[macro_export] to the new attribute parsing infrastructure)
- rust-lang#146486 (Improve
core::sync::atomiccoverage) - rust-lang#146606 (ci: x86_64-gnu-tools: Add
--test-argsregression test) - rust-lang#146639 (std: merge definitions of
StdioPipes)
r? @ghost
@rustbot modify labels: rollup
Labels
Area: Our Github Actions CI
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the infrastructure team, which will review and decide on the PR/issue.