Port `feature` to the new attribute system by jdonszelmann · Pull Request #146652 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation29 Commits2 Checks10 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot added A-attributes

Area: Attributes (`#[…]`, `#![…]`)

S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

T-rust-analyzer

Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

labels

Sep 16, 2025

error[E0565]: malformed `feature` attribute input
--> $DIR/gated-bad-feature.rs:1:1
\|
LL \| #![feature(foo_bar_baz, foo(bar), foo = "baz", foo)]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on a PR to re-improve these diagnostics (but for all attrs)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment has been minimized.

This comment was marked as resolved.

rustbot removed the S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

label

Sep 18, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This was referenced

Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with the naming issue fixed.

@bors delegate=jdonszelmann

thanks nicholas! that's a fair point

@bors r=nnethercote

📌 Commit 858e26c has been approved by nnethercote

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Sep 22, 2025

Zalathar added a commit to Zalathar/rust that referenced this pull request

Sep 22, 2025

…parser, r=nnethercote

Port feature to the new attribute system

bors added a commit that referenced this pull request

Sep 22, 2025

Rollup of 10 pull requests

Successful merges:

#145411 (regression test for Cow<[u8]> layout)
#146317 (Add panic=immediate-abort)
#146397 (std_detect on Darwin AArch64: update features)
#146594 (bootstrap: Don't force -static for musl targets in cc-rs)
#146652 (Port feature to the new attribute system)
#146791 (emit attribute for readonly non-pure inline assembly)
#146831 (Support ctr and lr as clobber-only registers in PowerPC inline assembly)
#146838 (Introduce "wrapper" helpers to rustdoc)
#146846 (btree InternalNode::new safety comments)
#146858 (Make mips64el-unknown-linux-muslabi64 link dynamically)

r? @ghost @rustbot modify labels: rollup

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Sep 22, 2025

This comment has been minimized.

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot added S-blocked

Status: Blocked on something else such as an RFC or other implementation work.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Sep 28, 2025

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_attr_parsing v0.0.0 (/checkout/compiler/rustc_attr_parsing)
error: unused import: `LimitInvalid`
 --> compiler/rustc_attr_parsing/src/attributes/crate_level.rs:2:61
  |
2 | use crate::session_diagnostics::{FeatureExpectedSingleWord, LimitInvalid};
  |                                                             ^^^^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(unused_imports)]`

Zalathar added a commit to Zalathar/rust that referenced this pull request

Sep 29, 2025

…nethercote

improve diagnostics for empty attributes

Adds a note about them not having any effect. This was previously done for feature attributes but no other attributes. In converting the feature parser I removed that note. This PR adds it back in and makes it so all attributes benefit from it.

Not blocked on rust-lang#146652, either can merge first

rust-timer added a commit that referenced this pull request

Sep 29, 2025