refactor(rustdoc): Remove redundant langstr checks by epage · Pull Request #148056 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks11 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
These same checks feed into doctest.can_be_merged, making them redundant.
These same checks feed into doctest.can_be_merged,
making them redundant.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
r? @notriddle
rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
For quick reference:
| let is_standalone = !doctest.can_be_merged |
|---|
| | |
| | |
| | |
| | |
| | |
| let can_merge_doctests = can_merge_doctests |
|---|
| && lang_str.is_some_and(|lang_str |
| !lang_str.compile_fail && !lang_str.test_harness && !lang_str.standalone_crate |
| }); |
📌 Commit aec6d51 has been approved by GuillaumeGomez
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
jhpratt added a commit to jhpratt/rust that referenced this pull request
refactor(rustdoc): Remove redundant langstr checks
These same checks feed into doctest.can_be_merged, making them redundant.
bors added a commit that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- #147406 (Remove needs-asm-support directive in tests with explicit targets)
- #147790 (constify comparison traits on slices)
- #148056 (refactor(rustdoc): Remove redundant langstr checks)
- #148065 (compiletest: Add concrete examples for some config/test path fields)
- #148072 (Fix compiling
CondVar::wait_timeouton 32-bit Apple platforms) - #148073 (test(frontmatter): Rename tests to make coverage more obvious)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 5 pull requests
Successful merges:
- #147406 (Remove needs-asm-support directive in tests with explicit targets)
- #148056 (refactor(rustdoc): Remove redundant langstr checks)
- #148065 (compiletest: Add concrete examples for some config/test path fields)
- #148072 (Fix compiling
CondVar::wait_timeouton 32-bit Apple platforms) - #148073 (test(frontmatter): Rename tests to make coverage more obvious)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #148056 - epage:merged, r=GuillaumeGomez
refactor(rustdoc): Remove redundant langstr checks
These same checks feed into doctest.can_be_merged, making them redundant.
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request
Rollup of 5 pull requests
Successful merges:
- rust-lang/rust#147406 (Remove needs-asm-support directive in tests with explicit targets)
- rust-lang/rust#148056 (refactor(rustdoc): Remove redundant langstr checks)
- rust-lang/rust#148065 (compiletest: Add concrete examples for some config/test path fields)
- rust-lang/rust#148072 (Fix compiling
CondVar::wait_timeouton 32-bit Apple platforms) - rust-lang/rust#148073 (test(frontmatter): Rename tests to make coverage more obvious)
r? @ghost
@rustbot modify labels: rollup
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the rustdoc team, which will review and decide on the PR/issue.