Update git index before running diff-index by Kobzol · Pull Request #148500 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks11 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Nov 4, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

};

// We ignore the exit code, as it errors out when some files are modified.
let _ = git().args(["update-index", "--refresh", "-q"]).output();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this discards stderr as well as stdout — you probably only want to discard stdout.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to discard all crap from git 😆 But you're right that stderr might be useful.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say keep the stderr, otherwise if the user has any git shenanigans it will be extremely confusing

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Nov 6, 2025

Changed to only ignore stdout.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📌 Commit 69da9af has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Nov 11, 2025

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Nov 11, 2025

bors added a commit that referenced this pull request

Nov 11, 2025

Rollup of 6 pull requests

Successful merges:

#147753 (Suggest add bounding value for RangeTo)
#148080 ([rustdoc] Fix invalid jump to def macro link generation)
#148465 (Adjust spans into the for loops context before creating the new desugaring spans.)
#148500 (Update git index before running diff-index)
#148536 (cmse: add test for async and const functions)
#148819 (Remove specialized warning for removed target)

r? @ghost @rustbot modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request

Nov 11, 2025

Zalathar added a commit to Zalathar/rust that referenced this pull request

Nov 11, 2025

bors added a commit that referenced this pull request

Nov 12, 2025

Rollup of 12 pull requests

Successful merges:

#146627 (Simplify jemalloc setup)
#147753 (Suggest add bounding value for RangeTo)
#147974 (Improve diagnostics for buffer reuse with borrowed references)
#148080 ([rustdoc] Fix invalid jump to def macro link generation)
#148424 (bootstrap: Add snapshot tests for path-to-step handling)
#148500 (Update git index before running diff-index)
#148536 (cmse: add test for async and const functions)
#148770 (implement feature(c_variadic_naked_functions))
#148819 (Remove specialized warning for removed target)
#148830 (miri subtree update)
#148833 (Update rustbook dependencies)
#148841 (Remove more #[must_use] from portable-simd)

r? @ghost @rustbot modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request

Nov 12, 2025

bors added a commit that referenced this pull request

Nov 12, 2025

Rollup of 16 pull requests

Successful merges:

#146627 (Simplify jemalloc setup)
#147753 (Suggest add bounding value for RangeTo)
#147832 (rustdoc: Don't pass RenderOptions to DocContext)
#147974 (Improve diagnostics for buffer reuse with borrowed references)
#148080 ([rustdoc] Fix invalid jump to def macro link generation)
#148465 (Adjust spans into the for loops context before creating the new desugaring spans.)
#148500 (Update git index before running diff-index)
#148531 (rustc_target: introduce Abi, Env, Os)
#148536 (cmse: add test for async and const functions)
#148770 (implement feature(c_variadic_naked_functions))
#148780 (fix filecheck typos in tests)
#148819 (Remove specialized warning for removed target)
#148830 (miri subtree update)
#148833 (Update rustbook dependencies)
#148834 (fix(rustdoc): Color doctest errors)
#148841 (Remove more #[must_use] from portable-simd)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Nov 12, 2025

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Nov 12, 2025

Kobzol deleted the git-update-inex branch

November 12, 2025 06:51

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)