Add new Tier-3 target: riscv64im-unknown-none-elf by kevaundray · Pull Request #148790 · rust-lang/rust (original) (raw)

rustbot added the T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

label

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

…r=davidtwco,JonathanBrouwer

Add new Tier-3 target: riscv64im-unknown-none-elf

This PR proposes to add riscv64im-unknown-none-elf, a subset of the already supported riscv64imac-unknown-none-elf.

The motivation behind this PR is that we want to standardize (most) zkVMs on riscv64im-none and riscv64ima-none. Having different variants of riscv extensions, also seems to be within expectation, atleast with respects to riscv32.

Note: This does not mean that we will be able to remove riscv32im-risc0-zkvm-elf -- I am not aware of all of the dependents for this

Tier-3 Policy

A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

I assigned Rust Embedded Working Group, since they are already maintaining riscv64IMAC, though I am happy to assign myself.

Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.

It follows the naming convention of the other bare metal riscv targets

Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users.

This has the same requirements as riscv{32, 64}imac

Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.

Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.

The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.

Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via @) to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.

Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.

Tier 3 targets must be able to produce assembly using at least one of rustc's supported backends from any host target. (Having support in a fork of the backend is not sufficient, it must be upstream.)

Acknowledging the above.

bors added a commit that referenced this pull request

Rollup of 9 pull requests

Successful merges:

#148756 (Warn on codegen attributes on required trait methods)
#148790 (Add new Tier-3 target: riscv64im-unknown-none-elf)
#149271 (feat: dlopen Enzyme)
#149354 (Bootstrap config: libgccjit libs dir)
#149459 (std: sys: fs: uefi: Implement set_times and set_perm)
#149950 (Simplify how inline asm handles MaybeUninit)
#150000 (Port #[rustc_legacy_const_generics] to use attribute parser )
#150014 (Metadata loader cleanups)
#150021 (document that mpmc channels deliver an item to (at most) one receiver)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

…r=davidtwco,JonathanBrouwer

Add new Tier-3 target: riscv64im-unknown-none-elf

This PR proposes to add riscv64im-unknown-none-elf, a subset of the already supported riscv64imac-unknown-none-elf.

Note: This does not mean that we will be able to remove riscv32im-risc0-zkvm-elf -- I am not aware of all of the dependents for this

Tier-3 Policy

A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

I assigned Rust Embedded Working Group, since they are already maintaining riscv64IMAC, though I am happy to assign myself.

Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.

It follows the naming convention of the other bare metal riscv targets

Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users.

This has the same requirements as riscv{32, 64}imac

Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.

Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.

The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.

Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via @) to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.

Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.

Tier 3 targets must be able to produce assembly using at least one of rustc's supported backends from any host target. (Having support in a fork of the backend is not sufficient, it must be upstream.)

Acknowledging the above.

bors added a commit that referenced this pull request

Rollup of 8 pull requests

Successful merges:

#148756 (Warn on codegen attributes on required trait methods)
#148790 (Add new Tier-3 target: riscv64im-unknown-none-elf)
#149271 (feat: dlopen Enzyme)
#149459 (std: sys: fs: uefi: Implement set_times and set_perm)
#149950 (Simplify how inline asm handles MaybeUninit)
#150000 (Port #[rustc_legacy_const_generics] to use attribute parser )
#150014 (Metadata loader cleanups)
#150021 (document that mpmc channels deliver an item to (at most) one receiver)

r? @ghost @rustbot modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request

…r=davidtwco,JonathanBrouwer

Add new Tier-3 target: riscv64im-unknown-none-elf

This PR proposes to add riscv64im-unknown-none-elf, a subset of the already supported riscv64imac-unknown-none-elf.

Note: This does not mean that we will be able to remove riscv32im-risc0-zkvm-elf -- I am not aware of all of the dependents for this

Tier-3 Policy

A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

I assigned Rust Embedded Working Group, since they are already maintaining riscv64IMAC, though I am happy to assign myself.

Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.

It follows the naming convention of the other bare metal riscv targets

Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users.

This has the same requirements as riscv{32, 64}imac

Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.

Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.

The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.

Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via @) to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.

Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.

Tier 3 targets must be able to produce assembly using at least one of rustc's supported backends from any host target. (Having support in a fork of the backend is not sufficient, it must be upstream.)

Acknowledging the above.

bors added a commit that referenced this pull request

Rollup of 14 pull requests

Successful merges:

#148756 (Warn on codegen attributes on required trait methods)
#148790 (Add new Tier-3 target: riscv64im-unknown-none-elf)
#149271 (feat: dlopen Enzyme)
#149459 (std: sys: fs: uefi: Implement set_times and set_perm)
#149771 (bootstrap readme: make easy to read when editor wrapping is not enabled)
#149856 (Provide an extended framework for type visit, for use in rust-analyzer)
#149950 (Simplify how inline asm handles MaybeUninit)
#150014 (Metadata loader cleanups)
#150021 (document that mpmc channels deliver an item to (at most) one receiver)
#150022 (Generate macro expansion for rust compiler crates docs)
#150029 (Update books)
#150031 (assert impossible branch is impossible)
#150034 (do not add I-prioritize when F-* labels are present)
#150036 (Use the embeddable filename for coverage artifacts)

r? @ghost @rustbot modify labels: rollup

bors added a commit that referenced this pull request

Rollup of 13 pull requests

Successful merges:

#148756 (Warn on codegen attributes on required trait methods)
#148790 (Add new Tier-3 target: riscv64im-unknown-none-elf)
#149271 (feat: dlopen Enzyme)
#149459 (std: sys: fs: uefi: Implement set_times and set_perm)
#149771 (bootstrap readme: make easy to read when editor wrapping is not enabled)
#149856 (Provide an extended framework for type visit, for use in rust-analyzer)
#149950 (Simplify how inline asm handles MaybeUninit)
#150014 (Metadata loader cleanups)
#150021 (document that mpmc channels deliver an item to (at most) one receiver)
#150029 (Update books)
#150031 (assert impossible branch is impossible)
#150034 (do not add I-prioritize when F-* labels are present)
#150036 (Use the embeddable filename for coverage artifacts)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request