re-enable wasm abi test by folkertdev · Pull Request #148956 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks11 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

The wasm32-unknown-unknown ABI has been fixed for a while now #115666, so this test can be re-enabled and the fixme removed.

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

📌 Commit 583d5de has been approved by bjorn3

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Zalathar added a commit to Zalathar/rust that referenced this pull request

… r=bjorn3

re-enable wasm abi test

The wasm32-unknown-unknown ABI has been fixed for a while now rust-lang#115666, so this test can be re-enabled and the fixme removed.

r? @bjorn3

bors added a commit that referenced this pull request

Rollup of 10 pull requests

Successful merges:

#148416 (vec_recycle: implementation)
#148522 (Micro-optimize rustdoc search index parsing)
#148827 (Stabilize vec_into_raw_parts)
#148832 (Bump library dependencies)
#148836 (tweak primitive reference docs)
#148859 (Fix overflow-checks test for RISC-V target)
#148886 (Add riscv64a23-unknown-linux-gnu to build-manifest TARGETS)
#148956 (re-enable wasm abi test)
#148963 (runtest.rs: remove redundant check)
#148968 (Add another ExprWithBlock test for try blocks)

r? @ghost @rustbot modify labels: rollup

bors added a commit that referenced this pull request

Rollup of 11 pull requests

Successful merges:

#148416 (vec_recycle: implementation)
#148522 (Micro-optimize rustdoc search index parsing)
#148827 (Stabilize vec_into_raw_parts)
#148832 (Bump library dependencies)
#148836 (tweak primitive reference docs)
#148859 (Fix overflow-checks test for RISC-V target)
#148886 (Add riscv64a23-unknown-linux-gnu to build-manifest TARGETS)
#148956 (re-enable wasm abi test)
#148963 (runtest.rs: remove redundant check)
#148968 (Add another ExprWithBlock test for try blocks)
#148984 (chore: Update annotate-snippets to 0.12.9)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Rollup merge of #148956 - folkertdev:reenable-wasm-abi-test, r=bjorn3

re-enable wasm abi test

The wasm32-unknown-unknown ABI has been fixed for a while now #115666, so this test can be re-enabled and the fixme removed.

r? @bjorn3

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Relevant to the compiler team, which will review and decide on the PR/issue.