ignore unsized types in mips64 and sparc64 callconvs by folkertdev · Pull Request #149041 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks11 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Non-rustic calling conventions should not make up an ABI for unsized types (cc #148302). The vast majority of our callconv implementations already ignore unsized types, sparc64 and mips64 I guess were missed.

r? @bjorn3

rustbot added the T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

label

Nov 17, 2025

📌 Commit bbf7dc0 has been approved by bjorn3

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Nov 19, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Nov 19, 2025

…nsized, r=bjorn3

ignore unsized types in mips64 and sparc64 callconvs

Non-rustic calling conventions should not make up an ABI for unsized types (cc rust-lang#148302). The vast majority of our callconv implementations already ignore unsized types, sparc64 and mips64 I guess were missed.

r? @bjorn3

bors added a commit that referenced this pull request

Nov 19, 2025

Rollup of 7 pull requests

Successful merges:

#146341 (minimal dirfd implementation (1/4))
#146925 (Add doc for va_list APIs)
#147035 (alloc: fix Debug implementation of ExtractIf)
#147173 (Add support for hexagon-unknown-qurt target)
#149041 (ignore unsized types in mips64 and sparc64 callconvs)
#149056 (fix the fragment_in_dst_padding_gets_overwritten test on s390x)
#149095 (rustc-dev-guide subtree update)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Nov 19, 2025

…nsized, r=bjorn3

ignore unsized types in mips64 and sparc64 callconvs

r? @bjorn3

bors added a commit that referenced this pull request

Nov 20, 2025

Rollup of 6 pull requests

Successful merges:

#146925 (Add doc for va_list APIs)
#147035 (alloc: fix Debug implementation of ExtractIf)
#147173 (Add support for hexagon-unknown-qurt target)
#149041 (ignore unsized types in mips64 and sparc64 callconvs)
#149056 (fix the fragment_in_dst_padding_gets_overwritten test on s390x)
#149095 (rustc-dev-guide subtree update)

r? @ghost @rustbot modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request

Nov 20, 2025

…nsized, r=bjorn3

ignore unsized types in mips64 and sparc64 callconvs

r? @bjorn3

bors added a commit that referenced this pull request

Nov 20, 2025

Rollup of 9 pull requests

Successful merges:

#146925 (Add doc for va_list APIs)
#147035 (alloc: fix Debug implementation of ExtractIf)
#147173 (Add support for hexagon-unknown-qurt target)
#148261 (rustc_public: Make Id types !Send / !Sync)
#149041 (ignore unsized types in mips64 and sparc64 callconvs)
#149043 ( rustdoc-json: add rlib path to ExternalCrate to enable robust crate resolution)
#149056 (fix the fragment_in_dst_padding_gets_overwritten test on s390x)
#149095 (rustc-dev-guide subtree update)
#149108 ([AIX][ppc64le-linux-gnu] Add Amy Kwan to target maintainers)