num: Implement uint_gather_scatter_bits feature for unsigned integers by okaneco · Pull Request #149097 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation12 Commits1 Checks11 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Feature gate: #![feature(uint_gather_scatter_bits)]
Tracking issue: #149069
Accepted ACP: rust-lang/libs-team#695 (comment)
Implement gather_bits, scatter_bits functions on unsigned integers
Add tests to coretests
This implementation is a small improvement over the plain naive form (see the solution sketch).
We only check the set bits in the mask instead of iterating over every bit.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #[unstable(feature = "uint_gather_scatter_bits", issue = "149069")] |
|---|
| #[must_use = "this returns the result of the operation, \ |
| without modifying the original"] |
| #[inline(always)] |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #[inline(always)] |
|---|
| #[inline] |
This seems more appropriate for something with a nontrivial amount of code within. Comparable to wrapping_pow.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with this, and changed the function signatures to be mut param instead of redeclaring in the function body.
Implement gather_bits, scatter_bits functions on unsigned integers
Add tests to coretests
📌 Commit 7f89192 has been approved by Mark-Simulacrum
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Zalathar added a commit to Zalathar/rust that referenced this pull request
…k-Simulacrum
num: Implement uint_gather_scatter_bits feature for unsigned integers
Feature gate: #![feature(uint_gather_scatter_bits)]
Tracking issue: rust-lang#149069
Accepted ACP: rust-lang/libs-team#695 (comment)
Implement gather_bits, scatter_bits functions on unsigned integers
Add tests to coretests
This implementation is a small improvement over the plain naive form (see the solution sketch). We only check the set bits in the mask instead of iterating over every bit.
Zalathar added a commit to Zalathar/rust that referenced this pull request
…k-Simulacrum
num: Implement uint_gather_scatter_bits feature for unsigned integers
Feature gate: #![feature(uint_gather_scatter_bits)]
Tracking issue: rust-lang#149069
Accepted ACP: rust-lang/libs-team#695 (comment)
Implement gather_bits, scatter_bits functions on unsigned integers
Add tests to coretests
This implementation is a small improvement over the plain naive form (see the solution sketch). We only check the set bits in the mask instead of iterating over every bit.
Zalathar added a commit to Zalathar/rust that referenced this pull request
…k-Simulacrum
num: Implement uint_gather_scatter_bits feature for unsigned integers
Feature gate: #![feature(uint_gather_scatter_bits)]
Tracking issue: rust-lang#149069
Accepted ACP: rust-lang/libs-team#695 (comment)
Implement gather_bits, scatter_bits functions on unsigned integers
Add tests to coretests
This implementation is a small improvement over the plain naive form (see the solution sketch). We only check the set bits in the mask instead of iterating over every bit.
bors added a commit that referenced this pull request
Rollup of 19 pull requests
Successful merges:
- #148048 (Stabilize
maybe_uninit_write_slice) - #148641 (Add a diagnostic attribute for special casing const bound errors for non-const impls)
- #148765 (std: split up the
threadmodule) - #149074 (Add Command::get_env_clear)
- #149097 (num: Implement
uint_gather_scatter_bitsfeature for unsigned integers) - #149131 (optimize
slice::Iter::next_chunk) - #149190 (Forbid
CHECK: brandCHECK-NOT: brin codegen tests (suggestbr {{.*}}instead)) - #149239 (clarify float min/max behavios for NaNs and signed zeros)
- #149243 (Fix typo and clarify bootstrap change tracker entry)
- #149270 (implement
Iterator::{exactly_one, collect_array}) - #149295 (Suggest _bytes versions of endian-converting methods)
- #149301 (Motor OS: make decode_error_kind more comprehensive)
- #149306 (bootstrap: Miri now handles jemalloc like everything else)
- #149325 (rustdoc: add regression test for #140968)
- #149332 (fix rustdoc search says “Consider searching for "null" instead.” #149324)
- #149349 (Fix typo in comment.)
- #149353 (Tidying up UI tests [3/N])
- #149355 (Document that
build.descriptionaffects symbol mangling and crate IDs) - #149360 (Enable CI download for windows-gnullvm)
r? @ghost
@rustbot modify labels: rollup
bors added a commit that referenced this pull request
Rollup of 12 pull requests
Successful merges:
- #147115 (More robust stack protector testing)
- #148048 (Stabilize
maybe_uninit_write_slice) - #148641 (Add a diagnostic attribute for special casing const bound errors for non-const impls)
- #149074 (Add Command::get_env_clear)
- #149097 (num: Implement
uint_gather_scatter_bitsfeature for unsigned integers) - #149131 (optimize
slice::Iter::next_chunk) - #149190 (Forbid
CHECK: brandCHECK-NOT: brin codegen tests (suggestbr {{.*}}instead)) - #149239 (clarify float min/max behavios for NaNs and signed zeros)
- #149243 (Fix typo and clarify bootstrap change tracker entry)
- #149301 (Motor OS: make decode_error_kind more comprehensive)
- #149306 (bootstrap: Miri now handles jemalloc like everything else)
- #149325 (rustdoc: add regression test for #140968)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #149097 - okaneco:gather_scatter_bits, r=Mark-Simulacrum
num: Implement uint_gather_scatter_bits feature for unsigned integers
Feature gate: #![feature(uint_gather_scatter_bits)]
Tracking issue: #149069
Accepted ACP: rust-lang/libs-team#695 (comment)
Implement gather_bits, scatter_bits functions on unsigned integers
Add tests to coretests
This implementation is a small improvement over the plain naive form (see the solution sketch). We only check the set bits in the mask instead of iterating over every bit.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.