Port the #![windows_subsystem] attribute to the new attribute system by scrabsha · Pull Request #149363 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation12 Commits1 Checks12 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Part of #131229.
I think it's worth running the Windows test suite before merging that (I don't have the rights for this).
Some changes occurred in compiler/rustc_hir/src/attrs
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
Some changes occurred in compiler/rustc_attr_parsing
Area: Attributes (`#[…]`, `#![…]`)
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
uh, I think this should be the right job:
@bors try jobs=x86_64-msvc
This comment has been minimized.
rust-bors bot added a commit that referenced this pull request
Port the #![windows_subsystem] attribute to the new attribute system
try-job: x86_64-msvc
This comment was marked as off-topic.
This comment was marked as off-topic.
Close, missing a -1.
@bors try jobs=x86_64-msvc-1
This comment has been minimized.
rust-bors bot added a commit that referenced this pull request
Port the #![windows_subsystem] attribute to the new attribute system
try-job: x86_64-msvc-1
☀️ Try build successful (CI)
Build commit: a16778f (a16778f2dc05e6f49d23e40e50cb67acf80b0f3e, parent: a4175159da185130408f71d7aa7e9bff0d455c24)
📌 Commit 2ab2090 has been approved by jdonszelmann
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- #147071 (constify from_fn, try_from_fn, try_map, map)
- #148930 (tweak editor configs)
- #149320 (-Znext-solver: normalize expected function input types when fudging)
- #149363 (Port the
#![windows_subsystem]attribute to the new attribute system) - #149378 (make run-make tests use 2024 edition by default)
- #149381 (Add
impl TrustedLenonBTree{Map,Set}iterators) - #149388 (remove session+blob decoder construction)
- #149390 (
rust-analyzersubtree update)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #149363 - scrabsha:rust/sasha/vkknqylzvzlu, r=jdonszelmann
Port the #![windows_subsystem] attribute to the new attribute system
Part of #131229.
I think it's worth running the Windows test suite before merging that (I don't have the rights for this).
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request
Labels
Area: Attributes (`#[…]`, `#![…]`)
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.