tidy: Detect outdated workspaces in workspace list by clubby789 · Pull Request #149417 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Detects the case in #149415 (will pass CI once that lands).

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

rustbot added the T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

label

Nov 28, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This comment has been minimized.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if path == "." { root.to_path_buf() } else { t!(root.join(path).canonicalize()) };
let canonicalized_root_real = t!(metadata.workspace_root.canonicalize());
if canonicalized_root_real != canonicalized_root {
check.error(format!("{path} is part of another workspace, remove from `WORKSPACES` ({WORKSPACE_LOCATION})"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have a check somewhere that we're covering all workspaces, right? Or is that missing?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no such check. And in fact we don't cover all workspaces. There are a bunch of workspaces that are neither used by x.py nor vendored. All workspaces that aren't vendored can't be linted by tidy without breaking offline builds.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Yeah, I guess that makes sense. Might be good to try to find a way to at least check those used by x.py, but not sure how we'd actually accomplish that in a useful way.

📌 Commit c906b2a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 10, 2025

Zalathar added a commit to Zalathar/rust that referenced this pull request

Dec 10, 2025

…Mark-Simulacrum

tidy: Detect outdated workspaces in workspace list

Detects the case in rust-lang#149415 (will pass CI once that lands).

Zalathar added a commit to Zalathar/rust that referenced this pull request

Dec 10, 2025

…Mark-Simulacrum

tidy: Detect outdated workspaces in workspace list

Detects the case in rust-lang#149415 (will pass CI once that lands).

bors added a commit that referenced this pull request

Dec 10, 2025

Rollup of 12 pull requests

Successful merges:

#147602 (Deduplicate higher-ranked lifetime capture errors in impl Trait)
#147725 (Remove -Zoom=panic)
#148294 (callconv: fix mips64 aggregate argument passing for C FFI)
#148491 ( Correctly provide suggestions when encountering async fn with a dyn Trait return type)
#149417 (tidy: Detect outdated workspaces in workspace list)
#149458 (Run clippy on cg_gcc in CI)
#149679 (Restrict spe_acc to PowerPC SPE targets)
#149781 (Don't suggest wrapping attr in unsafe if it may come from proc macro)
#149795 (Use let...else instead of match foo { ... _ => return }; and if let ... else return in std)
#149816 (Make typo in field and name suggestions verbose)
#149824 (Add a regression test for issue 145748)
#149826 (compiletest: tidy up adb_path/adb_test_dir handling)