Cleanup of attribute parsing errors by JonathanBrouwer · Pull Request #149949 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation19 Commits6 Checks11 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Removes the specific UnknownMetaItem and IllFormedAttributeInputLint errors.
Note that IllFormedAttributeInputLint is not a lint, contrary to its name

r? @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

rustbot added A-attributes

Area: Attributes (`#[…]`, `#![…]`)

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 13, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Dec 13, 2025

| | | | | ------------------------------------------------------------------------------------------------------------------------ | | | | expected this to be a list | | | | | | | = note: for more information, visit https://doc.rust-lang.org/reference/items/external-blocks.html#the-link-attribute | |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm we don't give any actual usage examples here 🤔

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only the link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is because of #149917
#[link] has too many examples so it decides not to show any.
I'm currently actually working on improving this system, this PR is the first in a series. I want to give more contextual usage examples.
Lets fix this in a future PR

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 13, 2025

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Dec 13, 2025

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Dec 13, 2025

@bors r=jdonszelmann rollup

📌 Commit ae39d3d has been approved by jdonszelmann

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Dec 13, 2025

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request

Dec 13, 2025

…donszelmann

Cleanup of attribute parsing errors

Removes the specific UnknownMetaItem and IllFormedAttributeInputLint errors. Note that IllFormedAttributeInputLint is not a lint, contrary to its name

r? @jdonszelmann

bors added a commit that referenced this pull request

Dec 13, 2025

…uwer

Rollup of 5 pull requests

Successful merges:

#148755 (Constify DropGuard::dismiss and trait impls)
#148825 (Add SystemTime::{MIN, MAX})
#149894 (Update to mdbook 0.5)
#149930 (std: small sys refactor)
#149949 (Cleanup of attribute parsing errors)

r? @ghost @rustbot modify labels: rollup

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request

Dec 13, 2025

…donszelmann

Cleanup of attribute parsing errors

Removes the specific UnknownMetaItem and IllFormedAttributeInputLint errors. Note that IllFormedAttributeInputLint is not a lint, contrary to its name

r? @jdonszelmann

bors added a commit that referenced this pull request

Dec 13, 2025

…uwer

Rollup of 5 pull requests

Successful merges:

#148755 (Constify DropGuard::dismiss and trait impls)
#148825 (Add SystemTime::{MIN, MAX})
#149894 (Update to mdbook 0.5)
#149949 (Cleanup of attribute parsing errors)
#149955 (Fix typo in armv7a-vex-v5 documentation)

r? @ghost @rustbot modify labels: rollup

bors added a commit that referenced this pull request

Dec 14, 2025

…uwer

Rollup of 5 pull requests

Successful merges:

#148755 (Constify DropGuard::dismiss and trait impls)
#148825 (Add SystemTime::{MIN, MAX})
#149894 (Update to mdbook 0.5)
#149949 (Cleanup of attribute parsing errors)
#149955 (Fix typo in armv7a-vex-v5 documentation)

r? @ghost @rustbot modify labels: rollup

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request

Dec 14, 2025

…donszelmann

Cleanup of attribute parsing errors

Removes the specific UnknownMetaItem and IllFormedAttributeInputLint errors. Note that IllFormedAttributeInputLint is not a lint, contrary to its name

r? @jdonszelmann

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Dec 14, 2025

…donszelmann

Cleanup of attribute parsing errors

Removes the specific UnknownMetaItem and IllFormedAttributeInputLint errors. Note that IllFormedAttributeInputLint is not a lint, contrary to its name

r? @jdonszelmann

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Dec 14, 2025

…donszelmann

Cleanup of attribute parsing errors

Removes the specific UnknownMetaItem and IllFormedAttributeInputLint errors. Note that IllFormedAttributeInputLint is not a lint, contrary to its name

r? @jdonszelmann

bors added a commit that referenced this pull request

Dec 14, 2025

Rollup of 7 pull requests

Successful merges:

#146794 (std: reorganize pipe implementations)
#148196 (Implement create_dir_all() to operate iteratively instead of recursively)
#148490 (dangling pointer from temp cleanup)
#149864 (std: Don't use linkat on the wasm32-wasi* targets)
#149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
#149949 (Cleanup of attribute parsing errors)
#149969 (don't use no_main and no_core to test IBT)

Failed merges:

#148847 (Share Timespec between Unix and Hermit)

r? @ghost @rustbot modify labels: rollup

bors added a commit that referenced this pull request

Dec 14, 2025

Rollup of 8 pull requests

Successful merges:

#146794 (std: reorganize pipe implementations)
#148490 (dangling pointer from temp cleanup)
#149837 (Update wrapping_sh[lr] docs and examples)
#149864 (std: Don't use linkat on the wasm32-wasi* targets)
#149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
#149949 (Cleanup of attribute parsing errors)
#149969 (don't use no_main and no_core to test IBT)
#149998 (miri subtree update)

r? @ghost @rustbot modify labels: rollup

bors added a commit that referenced this pull request

Dec 15, 2025

Rollup of 8 pull requests

Successful merges:

#146794 (std: reorganize pipe implementations)
#148490 (dangling pointer from temp cleanup)
#149837 (Update wrapping_sh[lr] docs and examples)
#149864 (std: Don't use linkat on the wasm32-wasi* targets)
#149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
#149949 (Cleanup of attribute parsing errors)
#149969 (don't use no_main and no_core to test IBT)
#149998 (miri subtree update)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit that referenced this pull request

Dec 15, 2025

Rollup merge of #149949 - JonathanBrouwer:error_cleanup, r=jdonszelmann

Cleanup of attribute parsing errors

Removes the specific UnknownMetaItem and IllFormedAttributeInputLint errors. Note that IllFormedAttributeInputLint is not a lint, contrary to its name

r? @jdonszelmann

Labels

A-attributes

Area: Attributes (`#[…]`, `#![…]`)

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.