Logfile output from tests; summarise in make check by grahame · Pull Request #2127 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation1 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Add an optional --logfile argument to std::test::test_main and to
compiletest.
Use this features and the new 'check-summary.py' script to
summarise all the tests performed by the 'check' target. This is
a short term fix for #2075.
Add an optional --logfile argument to std::test::test_main and to compiletest.
Use this features and the new 'check-summary.py' script to summarise all the tests performed by the 'check' target. This is a short term fix for #2075.
celinval added a commit to celinval/rust-dev that referenced this pull request
I updated the firecracker codegen test to use cargo kani assess instead and I removed the old scripts to collect info on the top X crates since we no longer use them.
I kept the compiler option --reachability=legacy since we still use it to test the std library code generation. I also kept the --mir-linker option as a no-op for now.
epage added a commit to epage/rust that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
epage added a commit to epage/rust that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
Kobzol pushed a commit to Kobzol/rust that referenced this pull request
bors pushed a commit to rust-lang-ci/rust that referenced this pull request
epage added a commit to epage/rust that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
epage added a commit to epage/rust that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
epage added a commit to epage/rust that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
epage added a commit to epage/rust that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
epage added a commit to epage/rust that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
fix(libtest): Deprecate '--logfile'
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile. The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with programmatic output. We acknowledge this is a problem to be evaluated but we need to make sure we are stepping back and gathering requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect any stable --format. As suggested above, we could specialize this to new --format values but that would be confusing for some values to apply but not others.
(2) Other ways of solving this add new features to libtest when we are instead wanting to limit the feature set it has to minimize the compatibility surface that has to be maintained and the burden it would put on third party harnesses which are a focus area. Examples include --format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways (rust-lang@5cc050b, rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended feature (see also
rust-lang#82350 (comment)). Deprecation would better match to how it has been treated. By deprecating this, we do not expect custom test harnesses (rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
Closes rust-lang/testing-devex-team#9
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
fix(libtest): Deprecate '--logfile'
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile. The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with programmatic output. We acknowledge this is a problem to be evaluated but we need to make sure we are stepping back and gathering requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect any stable --format. As suggested above, we could specialize this to new --format values but that would be confusing for some values to apply but not others.
(2) Other ways of solving this add new features to libtest when we are instead wanting to limit the feature set it has to minimize the compatibility surface that has to be maintained and the burden it would put on third party harnesses which are a focus area. Examples include --format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways (rust-lang@5cc050b, rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended feature (see also
rust-lang#82350 (comment)). Deprecation would better match to how it has been treated. By deprecating this, we do not expect custom test harnesses (rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
Closes rust-lang/testing-devex-team#9
jhpratt added a commit to jhpratt/rust that referenced this pull request
fix(libtest): Deprecate '--logfile'
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile. The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with programmatic output. We acknowledge this is a problem to be evaluated but we need to make sure we are stepping back and gathering requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect any stable --format. As suggested above, we could specialize this to new --format values but that would be confusing for some values to apply but not others.
(2) Other ways of solving this add new features to libtest when we are instead wanting to limit the feature set it has to minimize the compatibility surface that has to be maintained and the burden it would put on third party harnesses which are a focus area. Examples include --format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways (rust-lang@5cc050b, rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended feature (see also
rust-lang#82350 (comment)). Deprecation would better match to how it has been treated. By deprecating this, we do not expect custom test harnesses (rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
Closes rust-lang/testing-devex-team#9
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#134283 - epage:logfile, r=Amanieu
fix(libtest): Deprecate '--logfile'
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile. The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with programmatic output. We acknowledge this is a problem to be evaluated but we need to make sure we are stepping back and gathering requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect any stable --format. As suggested above, we could specialize this to new --format values but that would be confusing for some values to apply but not others.
(2) Other ways of solving this add new features to libtest when we are instead wanting to limit the feature set it has to minimize the compatibility surface that has to be maintained and the burden it would put on third party harnesses which are a focus area. Examples include --format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways (rust-lang@5cc050b, rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended feature (see also
rust-lang#82350 (comment)). Deprecation would better match to how it has been treated. By deprecating this, we do not expect custom test harnesses (rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
Closes rust-lang/testing-devex-team#9
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to carolynzech/rust that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to thanhnguyen-aws/verify-rust-std that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to thanhnguyen-aws/verify-rust-std that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to carolynzech/rust that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to thanhnguyen-aws/verify-rust-std that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to thanhnguyen-aws/verify-rust-std that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to carolynzech/rust that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to carolynzech/rust that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to thanhnguyen-aws/verify-rust-std that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to thanhnguyen-aws/verify-rust-std that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile.
The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with
programmatic output. We acknowledge this is a problem to be evaluated
but we need to make sure we are stepping back and gathering
requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect
any stable --format. As suggested above, we could specialize this to
new --format values but that would be confusing for some values to
apply but not others.
(2) Other ways of solving this add new features to libtest when we are
instead wanting to limit the feature set it has to minimize the
compatibility surface that has to be maintained and the burden it would
put on third party harnesses which are a focus area. Examples include
--format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways
(rust-lang@5cc050b,
rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended
feature (see also
rust-lang#82350 (comment)).
Deprecation would better match to how it has been treated.
By deprecating this, we do not expect custom test harnesses
(rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request
fix(libtest): Deprecate '--logfile'
rust-lang/testing-devex-team#9 proposed changing the behavior of --logfile. The given reasons were:
(1) Bazel can't programmatically process stdout. This seems like a limitation in Bazel and we recommend focusing on that. If we look at the wider Rust ecosystem, Rustc and Cargo don't support any such mechanism and the Cargo team rejected having one. Expecting this in libtest when its not supported elsewhere seems too specialized.
(2) Tests that leak out non-programmatic output that intermixes with programmatic output. We acknowledge this is a problem to be evaluated but we need to make sure we are stepping back and gathering requirements, rather than assuming --logfile will fit the needs.
Independent of the motive, regarding using or changing --logfile
(1) Most ways to do it would be a breaking change, like if we respect any stable --format. As suggested above, we could specialize this to new --format values but that would be confusing for some values to apply but not others.
(2) Other ways of solving this add new features to libtest when we are instead wanting to limit the feature set it has to minimize the compatibility surface that has to be maintained and the burden it would put on third party harnesses which are a focus area. Examples include --format compact or a --log-format flag
(3) The existence of --logfile dates back quite a ways (rust-lang@5cc050b, rust-lang#2127) and the history gives the
impression this more of slipped through rather than being an intended feature (see also
rust-lang#82350 (comment)). Deprecation would better match to how it has been treated. By deprecating this, we do not expect custom test harnesses (rust-lang/testing-devex-team#2) to implement this.
T-testing-devex held an FCP for deprecating in rust-lang/testing-devex-team#9 though according to RFC rust-lang#3455, this is still subject to final approval from T-libs-api.
Closes rust-lang/testing-devex-team#9
2 participants
