target spec: add an asm-args field to pass arguments to the external .. by japaric · Pull Request #38463 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

assembler

The main use case is the (still out of tree) msp430 target. For that target we use an external assembler, mps430-elf-gcc, to produce object files from the assembly rustc/llvm outputs. The problem is that by default msp430-elf-gcc produces object files for the MSP430X ABI but we want to use produce objects using the MSP430 (note: no X) ABI. To do that we have to pass -mcpu=msp430 to the assembler and that's what this flag is for.

r? @alexcrichton
cc @pftbest

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bors: r+

Looks good to me, thanks!

📌 Commit bd85a6d has been approved by alexcrichton

alexcrichton added a commit to alexcrichton/rust that referenced this pull request

Dec 20, 2016

target spec: add an asm-args field to pass arguments to the external ..

assembler

The main use case is the (still out of tree) msp430 target. For that target we use an external assembler, mps430-elf-gcc, to produce object files from the assembly rustc/llvm outputs. The problem is that by default msp430-elf-gcc produces object files for the MSP430X ABI but we want to use produce objects using the MSP430 (note: no X) ABI. To do that we have to pass -mcpu=msp430 to the assembler and that's what this flag is for.

r? @alexcrichton cc @pftbest

bors added a commit that referenced this pull request

Dec 20, 2016

Rollup of 29 pull requests

• Successful merges: #37761, #38006, #38131, #38150, #38158, #38171, #38208, #38215, #38236, #38245, #38289, #38302, #38315, #38346, #38388, #38395, #38398, #38418, #38432, #38451, #38463, #38468, #38470, #38471, #38472, #38478, #38486, #38493, #38498
• Failed merges: #38271, #38483