Don't suggest to use things which weren't found either by phungleson · Pull Request #39443 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Fixes #38054
The best code I can come up with, suggestions are welcome.
Basically, removing . Did you mean to use `DoesntExist1`? in the code below, because it is useless.
error[E0432]: unresolved import DoesntExist1
--> src/lib.rs:1:5
|
1 | use DoesntExist1;
| ^^^^^^^^^^^^ no DoesntExist1 in the root
error[E0432]: unresolved import DoesntExist2
--> src/lib.rs:2:5
|
2 | use DoesntExist2;
| ^^^^^^^^^^^^ no DoesntExist2 in the root. Did you mean to use DoesntExist1?
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
Yes, @phungleson, this looks like a good diff, but could you add a regression test? I think you would basically take your example and put it in the ui test suite, so we can check the precise output and make sure we are not giving the suggestion in question. (There are some instructions for the ui test suite in src/test/ui/README.md.)
Also removing the merge commit would be good =)
📌 Commit 823e185 has been approved by nikomatsakis
@phungleson looks good! I approved it for merging. The bors bot will take care of it now.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request
…, r=nikomatsakis
Don't suggest to use things which weren't found either
Fixes rust-lang#38054
The best code I can come up with, suggestions are welcome.
Basically, removing . Did you mean to use `DoesntExist1`? in the code below, because it is useless.
error[E0432]: unresolved import `DoesntExist1`
--> src/lib.rs:1:5
|
1 | use DoesntExist1;
| ^^^^^^^^^^^^ no `DoesntExist1` in the root
error[E0432]: unresolved import `DoesntExist2`
--> src/lib.rs:2:5
|
2 | use DoesntExist2;
| ^^^^^^^^^^^^ no `DoesntExist2` in the root. Did you mean to use `DoesntExist1`?frewsxcv added a commit to frewsxcv/rust that referenced this pull request
…, r=nikomatsakis
Don't suggest to use things which weren't found either
Fixes rust-lang#38054
The best code I can come up with, suggestions are welcome.
Basically, removing . Did you mean to use `DoesntExist1`? in the code below, because it is useless.
error[E0432]: unresolved import `DoesntExist1`
--> src/lib.rs:1:5
|
1 | use DoesntExist1;
| ^^^^^^^^^^^^ no `DoesntExist1` in the root
error[E0432]: unresolved import `DoesntExist2`
--> src/lib.rs:2:5
|
2 | use DoesntExist2;
| ^^^^^^^^^^^^ no `DoesntExist2` in the root. Did you mean to use `DoesntExist1`?frewsxcv added a commit to frewsxcv/rust that referenced this pull request
…, r=nikomatsakis
Don't suggest to use things which weren't found either
Fixes rust-lang#38054
The best code I can come up with, suggestions are welcome.
Basically, removing . Did you mean to use `DoesntExist1`? in the code below, because it is useless.
error[E0432]: unresolved import `DoesntExist1`
--> src/lib.rs:1:5
|
1 | use DoesntExist1;
| ^^^^^^^^^^^^ no `DoesntExist1` in the root
error[E0432]: unresolved import `DoesntExist2`
--> src/lib.rs:2:5
|
2 | use DoesntExist2;
| ^^^^^^^^^^^^ no `DoesntExist2` in the root. Did you mean to use `DoesntExist1`?frewsxcv added a commit to frewsxcv/rust that referenced this pull request
…, r=nikomatsakis
Don't suggest to use things which weren't found either
Fixes rust-lang#38054
The best code I can come up with, suggestions are welcome.
Basically, removing . Did you mean to use `DoesntExist1`? in the code below, because it is useless.
error[E0432]: unresolved import `DoesntExist1`
--> src/lib.rs:1:5
|
1 | use DoesntExist1;
| ^^^^^^^^^^^^ no `DoesntExist1` in the root
error[E0432]: unresolved import `DoesntExist2`
--> src/lib.rs:2:5
|
2 | use DoesntExist2;
| ^^^^^^^^^^^^ no `DoesntExist2` in the root. Did you mean to use `DoesntExist1`?bors added a commit that referenced this pull request
Rollup of 19 pull requests