Rollup of 10 pull requests by frewsxcv · Pull Request #39537 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits28 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

frewsxcv

@keeperofdakeys

This allows builtin derives to be registered and resolved, just like other derive types.

@keeperofdakeys

@nikomatsakis

The old code created a flat listing of "HIR -> WorkProduct" edges. While perfectly general, this could lead to a lot of repetition if the same HIR nodes affect many work-products. This is set to be a problem when we start to skip typeck, since we will be adding a lot more "work-product"-like nodes.

The newer code uses an alternative strategy: it "reduces" the graph instead. Basically we walk the dep-graph and convert it to a DAG, where we only keep intermediate nodes if they are used by multiple work-products.

This DAG does not contain the same set of nodes as the original graph, but it is guaranteed that (a) every output node is included in the graph and (b) the set of input nodes that can reach each output node is unchanged.

(Input nodes are basically HIR nodes and foreign metadata; output nodes are nodes that have assocaited state which we will persist to disk in some way. These are assumed to be disjoint sets.)

@keeperofdakeys

This removes the expand_derives function, and sprinkles the functionality throughout the Invocation Collector, Expander and Resolver.

@nrc

@abonander

@phungleson

@djc

@djc

@djc

@alexcrichton

We should be sure to add our build system entry point!

Closes rust-lang#39476

@nikomatsakis

The old algorithm was O(graph)

@nikomatsakis

@phungleson

@nikomatsakis

@GuillaumeGomez

@brson

I already checked this into stable, but it needs to be on master/beta too.

@nikomatsakis

@frewsxcv

…3, r=mw

rewrite the predecessors code to create a reduced graph

The old code created a flat listing of "HIR -> WorkProduct" edges. While perfectly general, this could lead to a lot of repetition if the same HIR nodes affect many work-products. This is set to be a problem when we start to skip typeck, since we will be adding a lot more "work-product"-like nodes.

The newer code uses an alternative strategy: it "reduces" the graph instead. Basically we walk the dep-graph and convert it to a DAG, where we only keep intermediate nodes if they are used by multiple work-products.

This DAG does not contain the same set of nodes as the original graph, but it is guaranteed that (a) every output node is included in the graph and (b) the set of input nodes that can reach each output node is unchanged.

(Input nodes are basically HIR nodes and foreign metadata; output nodes are nodes that have assocaited state which we will persist to disk in some way. These are assumed to be disjoint sets.)

r? @michaelwoerister

Fixes rust-lang#39494

@frewsxcv

…eyfried

Expand derive macros in the MacroExpander

This removes the expand_derives function, and sprinkles the functionality throughout the Invocation Collector, Expander and Resolver.

r? @jseyfried

@frewsxcv

…, r=nikomatsakis

Don't suggest to use things which weren't found either

Fixes rust-lang#38054

The best code I can come up with, suggestions are welcome.

Basically, removing . Did you mean to use `DoesntExist1`? in the code below, because it is useless.

error[E0432]: unresolved import `DoesntExist1`
 --> src/lib.rs:1:5
  |
1 | use DoesntExist1;
  |     ^^^^^^^^^^^^ no `DoesntExist1` in the root

error[E0432]: unresolved import `DoesntExist2`
 --> src/lib.rs:2:5
  |
2 | use DoesntExist2;
  |     ^^^^^^^^^^^^ no `DoesntExist2` in the root. Did you mean to use `DoesntExist1`?

@frewsxcv

@frewsxcv

@frewsxcv

Fix bootstrap.py issues with new rustbuild build system (fixes rust-lang#39469)

@frewsxcv

rustbuild: Add x.py to source tarballs

We should be sure to add our build system entry point!

Closes rust-lang#39476

@frewsxcv

@frewsxcv

…sxcv

Add missing urls in HashMap

r? @frewsxcv

@frewsxcv

Update relnotes for 1.15.1

I already checked this into stable, but it needs to be on master/beta too.

@rust-highfive

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv

@bors

📌 Commit 183fed5 has been approved by frewsxcv

@bors

⌛ Testing commit 183fed5 with merge 6791962...

@bors