Handle extern functions and statics in save-analysis by nrc · Pull Request #40348 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation43 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

nrc mentioned this pull request

Mar 8, 2017

📌 Commit 0aceb99 has been approved by eddyb

arielb1 pushed a commit to arielb1/rust that referenced this pull request

Mar 9, 2017

Handle extern functions and statics in save-analysis

r? @eddyb

thread 'rustc' panicked at 'Name not in signature?', /checkout/src/libcore/option.rs:785

note: Run with `RUST_BACKTRACE=1` for a backtrace.

Build failed, waiting for other jobs to finish...

error: Could not compile `rustc_llvm`.

📌 Commit 4cf22cb has been approved by @eddyb

frewsxcv added a commit to frewsxcv/rust that referenced this pull request

Mar 18, 2017

Handle extern functions and statics in save-analysis

r? @eddyb

arielb1 pushed a commit to arielb1/rust that referenced this pull request

Mar 18, 2017

Handle extern functions and statics in save-analysis

r? @eddyb

bors added a commit that referenced this pull request

Mar 18, 2017

Rollup of 22 pull requests

Successful merges: #40241, #40346, #40348, #40377, #40398, #40409, #40441, #40445, #40509, #40521, #40523, #40532, #40538, #40564, #40581, #40583, #40588, #40589, #40590, #40603, #40611, #40621
Failed merges: #40501, #40541

Still broken, same error:

thread 'rustc' panicked at 'Name not in signature?', /checkout/src/libcore/option.rs:785

note: Run with `RUST_BACKTRACE=1` for a backtrace.

Build failed, waiting for other jobs to finish...

error: Could not compile `rustc_llvm`.

@bors r-

@arielb1 how do I repro this? We're passing everything on Travis and running x.py test locally is fine too.

@nrc

Try doing ../x.py dist.

Nope, dist works fine. This looks like a specific save-analysis error, but the only place (iirc) we run save-analysis in the the test suite is in two tests in run-make - both of which run fine. My only thought is that this is due to a combination of this PR and another one in the rollup? But I don't see anything that would affect save-analysis in the rollup. I've rebased and am running tests again locally to see if I can repro...

@bors: r=eddyb

Yet again, I still can't repro any failure with test or dist (which suggests that the problem is not with another PR, but perhaps platform specific?). I don't see any way to debug this further without bors having a run over it. I suppose this will fail and waste some time, but otherwise I'm stuck.

Please don't rollup this PR (or r- it).

📌 Commit 158079e has been approved by eddyb

⌛ Testing commit 158079e with merge 22ff5e0...

⌛ Testing commit 8f6b68c with merge e126c17...

📌 Commit d76daf5 has been approved by eddyb

⌛ Testing commit d76daf5 with merge 1f41ec8...