keep the AST node-id when lowering ExprKind::Range by arielb1 · Pull Request #40764 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation12 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
When the Range expression is the root of a constant, its node-id is
used for the def-id of the body, so it has to be preserved in the AST ->
HIR lowering.
Fixes #40749.
r? @eddyb
beta-nominating because regression
When the Range expression is the root of a constant, its node-id is used for the def-id of the body, so it has to be preserved in the AST -> HIR lowering.
Fixes rust-lang#40749.
📌 Commit 8ffe406 has been approved by eddyb
Marking as beta-accepted. Small patch, regression.
cc @rust-lang/compiler
alexcrichton added a commit to alexcrichton/rust that referenced this pull request
keep the AST node-id when lowering ExprKind::Range
When the Range expression is the root of a constant, its node-id is used for the def-id of the body, so it has to be preserved in the AST -> HIR lowering.
Fixes rust-lang#40749.
r? @eddyb beta-nominating because regression
bors added a commit that referenced this pull request
Rollup of 11 pull requests
- Successful merges: #40347, #40501, #40516, #40524, #40540, #40642, #40683, #40764, #40778, #40807, #40809
- Failed merges: #40771
bors added a commit that referenced this pull request
Rollup of 11 pull requests
- Successful merges: #40347, #40501, #40516, #40524, #40540, #40642, #40683, #40764, #40778, #40807, #40809
- Failed merges: #40771
⌛ Testing commit 8ffe406 with merge 4e9953d...
⌛ Testing commit 8ffe406 with merge 3e8c572...
bors added a commit that referenced this pull request
keep the AST node-id when lowering ExprKind::Range
When the Range expression is the root of a constant, its node-id is used for the def-id of the body, so it has to be preserved in the AST -> HIR lowering.
Fixes #40749.
r? @eddyb beta-nominating because regression
@arielb1 unfortunately this doesn't apply cleanly to the beta branch, would you mind looking into the backport?
frewsxcv added a commit to frewsxcv/rust that referenced this pull request
Labels
Accepted for backporting to the compiler in the beta channel.